| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
…errors Changelog-Fixed: lsps-plugin: JIT channel HTLCs now fail with temporary_channel_failure instead of being silently continued when channel opening fails.
| Back | FazBrowse Home | New Git URL |
Problem
In service.rs, handle_htlc_safe caught all errors from handle_htlc_inner and responded with "result": "continue" while only logging at debug! level. This silently swallowed failures during JIT channel opening - most critically, fundchannel failures caused by insufficient on-chain balance. The paying node received no failure signal and the operator had no actionable log output
Fix
Replace the catch-all continue with a typed dispatch on HtlcError:
The outer handle_htlc_safe still catches truly unexpected errors (deserialization and stuff like that) and continues, which is the correct behaviour for unknown failures
Important
26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.
RC1 is scheduled on August 17th
The final release is scheduled for September 7th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: