Repository navigation
common: featurebits_unset cleared the whole byte - #9533
Open
kwsantiago wants to merge 2 commits into
Open
kwsantiago wants to merge 2 commits into
kwsantiago wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
kwsantiago
force-pushed
the
up-featurebits
branch
from
6fb5bce to
49171b9
Compare
September 20, 2026 23:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0 << n is always 0, so the mask clears every bit in the byte rather than the one asked for.
channel_type_accept() is the only caller: it blanks the variants (option_scid_alias 46, option_zeroconf 50) before comparing the proposal against the known types. Blanking 46 also clears bits 40-47, so option_provide_storage (42) and option_channel_type (44) disappear from the copy being compared, and a proposal carrying any of them still matches a known type. The type that gets stored afterwards is the peer's original vector, not the blanked one.
Nothing reads those bits back out of a channel type today, so this is a latent hole rather than a live bug.
Test added first; it fails on the current code:
Changelog-None