bolt2 says the receiver of splice_init / splice_ack / tx_init_rbf /tx_ack_rbf must fail (warning + disconnect, or error) if the sender s negative contribution is larger than their channel balance. We didnt check this on receipt. The overdraw was only caught in check_balances() after the whole interactive-tx negotiation, and answered with tx_abort
Changes:
splice_accepter() and splice_initiator() check the peers contribution against owed[REMOTE] right after parsing, and call peer_failed_warn() if it is too large
amount_msat_add_sat_s64() / amount_sat_add_sat_s64() negate as unsigned, so a peer-supplied INT64_MIN no longer causes signed overflow (UB, which aborts channeld in UBSan builds)
Tests:
New test_splice_out_exceeds_balance (fails before, passes after)
New test_amount_add_sat_s64() unit test, including INT64_MIN
Changelog-Fixed: channeld: reject a splice contribution larger than the peers balance on receipt, as required by bolt2
Important
26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.
RC1 is scheduled on August 17th
The final release is scheduled for September 7th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
The changelog has been updated in the relevant commit(s) according to the guidelines.
Tests have been added or modified to reflect the changes.
Documentation has been reviewed and updated as needed.
Related issues have been listed and linked, including any that this PR closes.
Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9566
bolt2 says the receiver of splice_init / splice_ack / tx_init_rbf /tx_ack_rbf must fail (warning + disconnect, or error) if the sender s negative contribution is larger than their channel balance. We didnt check this on receipt. The overdraw was only caught in check_balances() after the whole interactive-tx negotiation, and answered with tx_abort
Changes:
Tests:
Changelog-Fixed: channeld: reject a splice contribution larger than the peers balance on receipt, as required by bolt2
Important
26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.
RC1 is scheduled on August 17th
The final release is scheduled for September 7th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: