FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

channeld: reject splice contribution above peer balance on receipt by Andezion · Pull Request #9572 · ElementsProject/lightning · GitHub

Repository navigation

channeld: reject splice contribution above peer balance on receipt - #9572

Open
Andezion wants to merge 1 commit into
ElementsProject:masterfrom
Andezion:channeld/reject-splice-overdraw-on-receipt
Open

Andezion wants to merge 1 commit into
ElementsProject:masterfrom
Andezion:channeld/reject-splice-overdraw-on-receipt

Conversation

Copy link
Copy Markdown
Collaborator

Fixes #9566

bolt2 says the receiver of splice_init / splice_ack / tx_init_rbf /tx_ack_rbf must fail (warning + disconnect, or error) if the sender s negative contribution is larger than their channel balance. We didnt check this on receipt. The overdraw was only caught in check_balances() after the whole interactive-tx negotiation, and answered with tx_abort

Changes:

  • splice_accepter() and splice_initiator() check the peers contribution against owed[REMOTE] right after parsing, and call peer_failed_warn() if it is too large
  • amount_msat_add_sat_s64() / amount_sat_add_sat_s64() negate as unsigned, so a peer-supplied INT64_MIN no longer causes signed overflow (UB, which aborts channeld in UBSan builds)

Tests:

  • New test_splice_out_exceeds_balance (fails before, passes after)
  • New test_amount_add_sat_s64() unit test, including INT64_MIN

Changelog-Fixed: channeld: reject a splice contribution larger than the peers balance on receipt, as required by bolt2

Important

26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.

RC1 is scheduled on August 17th

The final release is scheduled for September 7th.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.
  • Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade

Andezion self-assigned this Sep 24, 2026
Changelog-Fixed: channeld: reject a splice contribution larger than the peers balance on receipt, as required by bolt2
Andezion force-pushed the channeld/reject-splice-overdraw-on-receipt branch from c92b4b1 to 50e3785 Compare September 24, 2026 22:08

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

channeld: splice_init taking out more than the peer's balance is acked, not rejected

1 participant


Back | FazBrowse Home | New Git URL