Pretty basic implementation of integer scaling. There are still a few problems with it, though.
It only works if the pixels are square. Using it on consoles like the NES and SNES that have rectangular pixels will result in uneven pixels (the exact thing integer scaling is meant to prevent). Setting their aspects to pixel-perfect and uncorrected respectively will fix this, but that's obviously not an optimal solution.
Effects generated by the core (i.e. snes9x blargg, fceumm ntsc filter) will make the canvas far too big, as they increase the size of the video
These 2 should be able to be fixed by using a different method of getting the size of the video stream.
The canvas won't resize if the video changes sizes (i.e. SNES changing to mode 5, PSX changing resolution)
The canvas is pinned to the top-right while integer scaling is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty basic implementation of integer scaling. There are still a few problems with it, though.
These 2 should be able to be fixed by using a different method of getting the size of the video stream.
This PR would resolve issue #1100