Bugfix/gearcoleco input mapping (#1256) - #1257
Open
Olliebrown wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
- Fixed scrambled 1 to 8 buttons - Added 0 and 9 (previously missing) - Added alternate 0 and 9 (also missing) Confirmed mapping for current gearcoleco core using the 'Final Test Cartridge (USA)'
ColecoVision - All specific to gearcoleco - There's no second analog stick so removed those from the analog list (enabling autofire) - Added keypad buttons for virtual gamepad on mobile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the gearcoleco control scheme mapping and virtual gamepad (Issue #1256). All low level inputs are properly available from gearcoleco and this fix exposes them all (including '0' and '9') and it fixes mappings so they match their visual labels.
It also updated the virtual gamepad with keypad buttons in the lower corners. Almost all games (all that I know of) require these keys in some form to be playable so this update makes that possible on mobile platforms without having to connect an external gamepad.