FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(ESGL): integrate ESGL natively by ripel2 · Pull Request #115 · EngineSquared/EngineSquared · GitHub

/ EngineSquared Public

feat(ESGL): integrate ESGL natively - #115

Merged
ripel2 merged 25 commits into
mainfrom
114-integrate-esgl-natively-in-the-core
Mar 14, 2025
ConversationCommits (25)ChecksFiles changed
Merged

feat(ESGL): integrate ESGL natively#115
ripel2 merged 25 commits into
mainfrom
114-integrate-esgl-natively-in-the-core

Conversation

ripel2 commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related to:

You can check that it works properly by trying to run this example by removing its explicit reference to ESGL

Notes:

  • namespace "ESGL" has been renamed to "ES::Plugin::OpenGL"
  • Globally, the ESGL plugin has been renamed to OpenGL

ripel2 added the critical Very important PR that requires @CoreTeam approval label Mar 11, 2025
ripel2 requested a review from a team March 11, 2025 15:57
ripel2 self-assigned this Mar 11, 2025
ripel2 linked an issue Mar 11, 2025 that may be closed by this pull request
Integrate ESGL natively in the core #114
Closed
ripel2 added the refactor Code Refactor label Mar 11, 2025
ripel2 and others added 18 commits March 11, 2025 17:03
ripel2 marked this pull request as ready for review March 12, 2025 10:59

ripel2 commented Mar 12, 2025

Copy link
Copy Markdown
Contributor Author

I should probably use sub namespaces for components, systems, and resources as well
@EngineSquared/coreteam ?

Miou-zora requested changes Mar 12, 2025
View reviewed changes

Miou-zora left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've named it ESGL for EngineSquared openGL so it doesn't make sense to name it ESGL, you should name it OpenGL or smth like this I think.

And yeah, you should add a sub namespaces for Systemes, Components etc.

Beside that, everything looks ok 👍🏼

Miou-zora requested a review from MasterLaplace March 12, 2025 13:18
Miou-zora requested a review from Divengerss March 12, 2025 13:18

sonarqubecloud Bot commented Mar 12, 2025

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ripel2 requested a review from Miou-zora March 12, 2025 15:13
MasterLaplace changed the title feat(ESGL) integrate ESGL natively feat(ESGL): integrate ESGL natively Mar 12, 2025
MasterLaplace suggested changes Mar 12, 2025
View reviewed changes
Comment thread src/plugin/esgl/src/resource/ESGLFWWINDOW/ESGLFWWINDOW.hpp Outdated
Comment thread src/plugin/opengl/src/system/AllSystems.hpp
Comment thread src/plugin/opengl/src/system/AllSystems.hpp
Comment thread src/plugin/opengl/src/utils/Viewer/Viewer.hpp
Comment thread src/plugin/opengl/tests/main.cpp
ripel2 requested a review from MasterLaplace March 13, 2025 14:25

ripel2 commented Mar 14, 2025

Copy link
Copy Markdown
Contributor Author

CI is stuck again, it was OK in the latest commit so I will force merge

ripel2 merged commit ad9ea30 into main Mar 14, 2025
ripel2 deleted the 114-integrate-esgl-natively-in-the-core branch March 14, 2025 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Miou-zora Miou-zora approved these changes
+2 more reviewers
MasterLaplace MasterLaplace approved these changes
Divengerss Divengerss approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

ripel2

Labels

critical Very important PR that requires @CoreTeam approval refactor Code Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate ESGL natively in the core

4 participants

Back | FazBrowse Home | New Git URL