FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Physics): JoltPhysics integration by ripel2 · Pull Request #154 · EngineSquared/EngineSquared · GitHub

/ EngineSquared Public

feat(Physics): JoltPhysics integration - #154

Merged
ripel2 merged 14 commits into
mainfrom
146-use-joltphysics-for-physics
Apr 1, 2025
ConversationCommits (14)ChecksFiles changed
Merged

feat(Physics): JoltPhysics integration#154
ripel2 merged 14 commits into
mainfrom
146-use-joltphysics-for-physics

Conversation

ripel2 commented Mar 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related to:

I have written a basic integration of JoltPhysics with out core. It replaces the existing physics plugin.
Most of this work is based on our PoC ESJolt and ESJolt-Test

To test, simply remove "ESJolt" from the "ESJolt-Test" and try to run it. (you can run on branch main, and you'll probably need to add the "stb" package in xmake.lua as well)

Notes:

  • The <Jolt/Jolt.h> header absolutely needs to be included before any other, but clang wants to sort it as alphabetical. Which is why it is disabled in some header files using a comment like // clang-format off

ripel2 linked an issue Mar 29, 2025 that may be closed by this pull request
Use JoltPhysics for physics #146
Closed
ripel2 requested a review from a team March 29, 2025 13:59
ripel2 self-assigned this Mar 29, 2025
ripel2 added critical Very important PR that requires @CoreTeam approval enhancement New feature or request labels Mar 29, 2025

ripel2 commented Mar 30, 2025

Copy link
Copy Markdown
Contributor Author

the two "TODOs" should be refactored in another issue

ripel2 marked this pull request as ready for review March 30, 2025 08:41

Miou-zora commented Mar 30, 2025

Copy link
Copy Markdown
Contributor


It should looks like this

Miou-zora requested changes Mar 30, 2025
View reviewed changes

Miou-zora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Everything's good! But can you add the "TODO" we added even if sonar is angry about it ?

ripel2 commented Mar 30, 2025

Copy link
Copy Markdown
Contributor Author

Everything's good! But can you add the "TODO" we added even if sonar is angry about it ?

yes, I think it is better to keep them in code as well (sorry sonar)
I added them back

ripel2 requested a review from Miou-zora March 30, 2025 09:35

sonarqubecloud Bot commented Mar 30, 2025

Copy link
Copy Markdown

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Miou-zora approved these changes Mar 30, 2025
View reviewed changes

Miou-zora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍🏼

ripel2 merged commit 8a52720 into main Apr 1, 2025
ripel2 deleted the 146-use-joltphysics-for-physics branch April 1, 2025 06:27
ripel2 mentioned this pull request Apr 1, 2025
Merged
ripel2 added a commit that referenced this pull request Apr 2, 2025
feat(physics): softbody integration (#156)
ddab79e 
Related to no issues (it was supposed to be in #154)

Notes:
- I fixed a bug in the Physics plugin: previously it used the deltaTime
of RelativeTimeUpdate but the systems themselves didn't use this
scheduler
- FixedTimeUpdate is used instead of RelativeTimeUpdate, otherwise the
simulation is not deterministic
- Transform scaling is not supported

(We should bump the default rate of the FixedTimeUpdate to something
higher)

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Miou-zora Miou-zora approved these changes
+2 more reviewers
MasterLaplace MasterLaplace approved these changes
Divengerss Divengerss approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

ripel2

Labels

critical Very important PR that requires @CoreTeam approval enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use JoltPhysics for physics

4 participants

Back | FazBrowse Home | New Git URL