feat(core): collider systems - #30
Merged
Miou-zora merged 4 commits intoOct 15, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
feat(collision): speed up collision detection
Closed
Copy link
Copy Markdown
Contributor
|
i'm curious how did you compute the complexity ? @Miou-zora |
Sorry, something went wrong.
ripel2
previously approved these changes
Oct 14, 2024
ripel2
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
it's basically a double for loop (O(n²)) which I cut in half because a collide with b is the same as b collide with a. (It's more like O(n²/2 - n/2) but n/2 is negligeable) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to:
I've added a dumb collision detector using a O(n²/2) algorithm