fix(graphic): update default material and texture initialization by Miou-zora · Pull Request #432 · EngineSquared/EngineSquared · GitHub

Removes explicit ambient color assignment from the default material and changes the default texture to a 1x1 fully white texture instead of a 2x2 colored texture. This simplifies the default resource setup.

Summary by CodeRabbit

Bug Fixes
- Adjusted default material ambient initialization behavior
- Updated default texture specifications to 1x1 size with white coloring

✏️ Tip: You can customize this high-level summary in your review settings.

Removes explicit ambient color assignment from the default material and changes the default texture to a 1x1 fully white texture instead of a 2x2 colored texture. This simplifies the default resource setup.

📝 Walkthrough

Walkthrough

Two initialization routines were modified: default material ambient color initialization was removed, and default texture properties were changed—size from 2×2 to 1×1 pixels and color from brownish (150, 100, 100) to white (255, 255, 255).

Changes

Cohort / File(s)	Summary
Material Initialization src/plugin/default-pipeline/src/system/initialization/CreateDefaultMaterial.cpp	Removed explicit initialization of defaultMaterial.ambient to glm::vec3(0.5f, 0.5f, 0.5f), now relies on default initialization.
Texture Initialization src/plugin/graphic/src/system/initialization/CreateDefaultTexture.cpp	Modified default texture: size reduced from 2×2 to 1×1 pixels; color changed from brownish (150, 100, 100, 255) to white (255, 255, 255, 255).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With whiskers bright and nose held high,
I hop through code with joyful sigh,
A texture white, a pixel small,
Default values, simple and all!
No ambient shades to slow me down,
Just cleaner code throughout the town!

🚥 Pre-merge checks | ✅ 2 | ❌ 1 ❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(graphic): update default material and texture initialization' accurately describes the main changes: removing ambient color assignment and replacing default texture setup.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix(graphic): update default material and texture initialization

a5225c9

Removes explicit ambient color assignment from the default material and changes the default texture to a 1x1 fully white texture instead of a 2x2 colored texture. This simplifies the default resource setup.

Miou-zora requested a review from a team January 24, 2026 10:08

Miou-zora self-assigned this Jan 24, 2026

Miou-zora added the enhancement New feature or request label Jan 24, 2026

Miou-zora added 2 commits January 24, 2026 14:56

Merge branch 'main' into set-correct-default-color-for-material

9e3b6da

Merge branch 'main' into set-correct-default-color-for-material

514c8e4

ripel2 approved these changes Jan 24, 2026

View reviewed changes

ripel2 merged commit 67ec0e7 into main Jan 24, 2026
15 checks passed

ripel2 deleted the set-correct-default-color-for-material branch January 24, 2026 16:32

This was referenced Jan 24, 2026

feat(graphic): support local and file-based textures in material setup #435

Merged

feat(graphic): use diffuse texture rather than ambiant texture #436

Merged

fix(graphic): update default material and texture initialization by Miou-zora · Pull Request #432 · EngineSquared/EngineSquared · GitHub

Uh oh!

fix(graphic): update default material and texture initialization - #432

fix(graphic): update default material and texture initialization#432
ripel2 merged 3 commits into
mainfrom
set-correct-default-color-for-material

Miou-zora commented Jan 24, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Jan 24, 2026 •
edited
Loading

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jan 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(graphic): update default material and texture initialization by Miou-zora · Pull Request #432 · EngineSquared/EngineSquared · GitHub

Uh oh!

fix(graphic): update default material and texture initialization - #432

fix(graphic): update default material and texture initialization#432ripel2 merged 3 commits intomainEngineSquared/EngineSquared:mainfrom set-correct-default-color-for-materialEngineSquared/EngineSquared:set-correct-default-color-for-materialCopy head branch name to clipboard

Conversation

Miou-zora commented Jan 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

sonarqubecloud Bot commented Jan 24, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(graphic): update default material and texture initialization#432
ripel2 merged 3 commits into
mainfrom
set-correct-default-color-for-material

Miou-zora commented Jan 24, 2026 •
edited by coderabbitai Bot
Loading

coderabbitai Bot commented Jan 24, 2026 •
edited
Loading