FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ui): update render pass dependency to use DEFERRED_PASS by Miou-zora · Pull Request #437 · EngineSquared/EngineSquared · GitHub

/ EngineSquared Public

fix(ui): update render pass dependency to use DEFERRED_PASS - #437

Merged
Divengerss merged 1 commit into
mainfrom
render-ui-after-deferred-pass
Jan 25, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix(ui): update render pass dependency to use DEFERRED_PASS#437
Divengerss merged 1 commit into
mainfrom
render-ui-after-deferred-pass

Conversation

Miou-zora commented Jan 24, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the dependency logic for the Rmlui render pipeline to ensure it integrates correctly with the deferred rendering pass. The main change is to check for and set dependencies against the DEFERRED_PASS instead of the previous DEFAULT_RENDER_PASS.

Render pipeline dependency update:

  • In CreateRmluiRenderPipeline.cpp, the code now checks for the existence of DEFERRED_PASS in the render graph and sets the dependency accordingly, replacing the old check and dependency on DEFAULT_RENDER_PASS.

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted rendering pipeline dependency configuration to ensure correct visual layer composition during rendering.

✏️ Tip: You can customize this high-level summary in your review settings.

Miou-zora requested a review from a team January 24, 2026 19:23
Miou-zora self-assigned this Jan 24, 2026

coderabbitai Bot commented Jan 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The RmlUI render pipeline configuration was updated to check for and depend on "DEFERRED_PASS" instead of "DEFAULT_RENDER_PASS". The dependency conditional and target were modified to integrate the render pipeline with deferred rendering passes.

Changes

Cohort / File(s) Summary
Render Pipeline Configuration
src/plugin/rmlui/src/system/CreateRmluiRenderPipeline.cpp		 Updated render graph dependency from "DEFAULT_RENDER_PASS" to "DEFERRED_PASS"; modified conditional check and dependency target to match.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A deferred pass now claims its due,
Where render pipelines once rang true,
The default fades, new lights align,
Our RmlUI graphics now will shine! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1 ❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the render pass dependency from DEFAULT_RENDER_PASS to DEFERRED_PASS in the Rmlui render pipeline.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

sonarqubecloud Bot commented Jan 24, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Divengerss merged commit a5f26d9 into main Jan 25, 2026
16 checks passed
Divengerss deleted the render-ui-after-deferred-pass branch January 25, 2026 10:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Divengerss Divengerss approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Miou-zora

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL