feat(log): add logging library using spdlog - #56
Merged
ripel2 merged 19 commits intoNov 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Closed
ripel2
reviewed
Nov 13, 2024
Comment thread
src/plugin/log/src/Logger.hpp
Outdated
Comment thread
src/plugin/vk-wrapper/src/VkWrapper.cpp
Comment thread
src/plugin/vk-wrapper/src/debugMessenger/DebugMessenger.cpp
Outdated
Comment thread
src/plugin/utils/tests/StringTest.cpp
Outdated
Comment thread
src/plugin/utils/src/String.hpp
Outdated
Comment thread
src/plugin/scene/tests/SceneTest.cpp
Comment thread
src/plugin/log/.gitignore
Outdated
Comment thread
src/plugin/log/src/Logger.cpp
Outdated
MasterLaplace
marked this pull request as draft
November 13, 2024 19:29
…eSquared/EngineSquared into 49-add-logging-possibility
…eSquared/EngineSquared into 49-add-logging-possibility
Miou-zora
requested review from
MasterLaplace and
ripel2
and removed request for
MasterLaplace and
ripel2
November 14, 2024 08:44
Miou-zora
requested review from
a team,
MasterLaplace and
ripel2
and removed request for
a team
November 14, 2024 08:44
MasterLaplace
marked this pull request as ready for review
November 14, 2024 08:45
MasterLaplace
approved these changes
Nov 14, 2024
ripel2
approved these changes
Nov 14, 2024
MasterLaplace
pushed a commit
that referenced
this pull request
Dec 6, 2024
I choose [`spdlog`](https://github.com/gabime/spdlog) for a logging library because it's the most common logging lib used for game engine and it looks perfect for our needs. So I've swited all std::cout and std::cerr of this project for logging functions that you can see in `Logger.hpp`. I also added a new utility namespace for strings. All game engine I know that use `spdlog`: [SupernovaEngine](https://github.com/skaarj1989/SupernovaEngine), [RendererEngine](https://github.com/JeanPhilippeKernel/RendererEngine), [ElvenEngine](https://github.com/denyskryvytskyi/ElvenEngine), [ezEngine](https://github.com/ezEngine/ezEngine), other game engine uses customs logger or don't provide infos about it. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Lucas Hauszler <70372762+ripel2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewersAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I choose spdlog for a logging library because it's the most common logging lib used for game engine and it looks perfect for our needs.
So I've swited all std::cout and std::cerr of this project for logging functions that you can see in Logger.hpp.
I also added a new utility namespace for strings.
All game engine I know that use spdlog: SupernovaEngine, RendererEngine, ElvenEngine, ezEngine, other game engine uses customs logger or don't provide infos about it.