FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Registry): add fixed update system management by Miou-zora · Pull Request #63 · EngineSquared/EngineSquared · GitHub

/ EngineSquared Public

feat(Registry): add fixed update system management - #63

Merged
ripel2 merged 8 commits into
mainfrom
61-fixed-update
Nov 26, 2024
ConversationCommits (8)ChecksFiles changed
Merged

feat(Registry): add fixed update system management#63
ripel2 merged 8 commits into
mainfrom
61-fixed-update

Conversation

Miou-zora commented Nov 24, 2024

Copy link
Copy Markdown
Contributor

I've added a way to add systems that will be added each specified ticks (50 per seconds per default). These systems should call Registry::GetFixedDeltaTime to get delta time rather than RealTimeProvider resource. I've also added a Clock that can be used as a clock to have specific tickrate.

Miou-zora linked an issue Nov 24, 2024 that may be closed by this pull request
Fixed update #61
Closed
Miou-zora requested a review from a team November 24, 2024 03:58
Miou-zora self-assigned this Nov 24, 2024
Miou-zora added the enhancement New feature or request label Nov 24, 2024
ripel2 reviewed Nov 25, 2024
View reviewed changes

ripel2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think it would be great to discuss about making the DeltaTime handling more coherent
Because right now we can have it directly in the registry for FixedDeltaTime but for RealTime we need to create and use a resource. Why should we create a resource for one and not the other ?

ripel2 commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

Also, when testing with the SB-Test-Scene, the systems do not run if the framerate is over 50FPS. Here is how I did it, maybe I did something wrong

ripel2 commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

Putting this PR in draft while we discuss it

ripel2 marked this pull request as draft November 25, 2024 15:16

sonarqubecloud Bot commented Nov 26, 2024

Copy link
Copy Markdown

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ripel2 commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

The bug of the systems not running is fixed

ripel2 marked this pull request as ready for review November 26, 2024 08:52
ripel2 merged commit 022e314 into main Nov 26, 2024
ripel2 deleted the 61-fixed-update branch November 26, 2024 08:57
MasterLaplace pushed a commit that referenced this pull request Dec 6, 2024
feat(Registry): add fixed update system management (#63)
067d990 
I've added a way to add systems that will be added each specified ticks
(50 per seconds per default). These systems should call
`Registry::GetFixedDeltaTime` to get delta time rather than
`RealTimeProvider` resource. I've also added a `Clock` that can be used
as a clock to have specific tickrate.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
ripel2 ripel2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Miou-zora

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fixed update

2 participants

Back | FazBrowse Home | New Git URL