feat(object): obj loader by MasterLaplace · Pull Request #72 · EngineSquared/EngineSquared · GitHub

Related to:

OBJ Loader #40

In short:

a vertex component to be used by the Vk-Wrapper, which stores the position of the points, the colour of each point and the texture coordinate
a mesh component that will also be used by the Vk-Wrapper, which stores the model's vertices and indices.
a MeshLoader to test the management of entt resources (optional)
OBJLoader is used to load models

All the classes have been tested and are working.

…t a vertex in a mesh

…a mesh

… vertices and indices

…t.hpp

…BJLoader

…pdate dependencies

…ind to static

… file loading

…cess

…ty in loadModel test

…ilure case

…sistency

…gement

…nce improvement

…onding asset

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

MasterLaplace added enhancement New feature or request test Additions or modifications to tests labels Dec 9, 2024

MasterLaplace requested a review from Miou-zora December 9, 2024 10:49

MasterLaplace self-assigned this Dec 9, 2024

MasterLaplace linked an issue Dec 9, 2024 that may be closed by this pull request

OBJ Loader #40

Closed

3 tasks

MasterLaplace and others added 20 commits December 9, 2024 05:51

feat(object): add the declaration of the Vertex structure to represen…

f0986b8

…t a vertex in a mesh

feat(object): add the declaration of the Mesh structure to represent …

0e8a84f

…a mesh

feat(object): implement OBJLoader for loading .obj files and managing…

cda8f50

… vertices and indices

feat(object): add inclusions for OBJLoader, Vertex, and Mesh in Objec…

b372439

…t.hpp

feat(object): add validation for model loading path in OBJLoader

d50f517

feat(object): reorder includes in Object.hpp and add unit tests for O…

6b6612f

…BJLoader

style: apply linter

054a214

feat(tests): add .obj files for model loading tests

eed6e74

fix(object): move TINYOBJLOADER_IMPLEMENTATION to OBJLoader.cpp and u…

edbba8a

…pdate dependencies

fix(tests): update OBJLoader tests to use a defined file path for assets

da879eb

style: apply linter

5a04226

fix(object): refactor OBJLoader to include Logger and change target k…

d0f16f1

…ind to static

fix(tests): update OBJLoader tests to use a new asset path and adjust…

e22afdd

… file loading

fix(build): update asset handling in xmake.lua for improved build pro…

b3c22c4

…cess

fix(tests): remove obsolete loadModel_fail test and associated asset

727892a

fix(build): remove obsolete test target configuration from xmake.lua

de8e13a

fix(tests): add assertions to verify vertices and indices are not emp…

0e6d7ca

…ty in loadModel test

refactor(mesh): update MeshLoader to use a functor for loading meshes

d85e575

test(mesh): add unit test for loading mesh from entt resource cache

f26bf0c

test(vertex): add unit tests for the Vertex structure

36b6fb0

MasterLaplace force-pushed the 40-obj-loader branch from 2c340a9 to 36b6fb0 Compare December 9, 2024 10:52

style: apply linter

8ba35a6

MasterLaplace marked this pull request as draft December 9, 2024 10:56

MasterLaplace added 2 commits December 9, 2024 06:11

refactor(vertex): simplify equality operator and add unit test for fa…

d711469

…ilure case

refactor(tests): rename test files and update test case names for con…

ae32655

…sistency

refactor(xmake): restructure build and clean functions for asset mana…

41de6fd

…gement

MasterLaplace marked this pull request as ready for review December 10, 2024 05:43

MasterLaplace requested review from a team and removed request for Miou-zora December 10, 2024 05:43

MasterLaplace added 2 commits December 15, 2024 14:06

fix: update dependency management and change build hook to after_build

4e64c62

refactor(OBJLoader): replace push_back with emplace_back for performa…

b225040

…nce improvement

ripel2 changed the title Obj loader and Entt Cache Loader test feat(vk-wrapper): obj loader and entt cache loader test Dec 15, 2024

ripel2 reviewed Dec 15, 2024

View reviewed changes

Comment thread src/plugin/object/src/component/Mesh.hpp

Comment thread src/plugin/object/src/resource/OBJLoader.hpp

Comment thread src/plugin/object/tests/OBJLoaderTest.cpp Outdated

ripel2 changed the title feat(vk-wrapper): obj loader and entt cache loader test feat(object): obj loader Dec 15, 2024

test(OBJLoader): update test case to use non-OBJ file and add corresp…

00bd96b

…onding asset

MasterLaplace requested a review from ripel2 December 15, 2024 20:38

ripel2 approved these changes Dec 16, 2024

View reviewed changes

Merge branch 'main' into 40-obj-loader

f1392ff

ripel2 merged commit 9270b8e into main Dec 16, 2024

ripel2 deleted the 40-obj-loader branch December 16, 2024 09:48

feat(object): obj loader by MasterLaplace · Pull Request #72 · EngineSquared/EngineSquared · GitHub

Uh oh!

feat(object): obj loader - #72

feat(object): obj loader#72
ripel2 merged 28 commits into
mainfrom
40-obj-loader

MasterLaplace commented Dec 9, 2024 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Dec 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(object): obj loader by MasterLaplace · Pull Request #72 · EngineSquared/EngineSquared · GitHub

Uh oh!

feat(object): obj loader - #72

feat(object): obj loader#72ripel2 merged 28 commits intomainEngineSquared/EngineSquared:mainfrom 40-obj-loaderEngineSquared/EngineSquared:40-obj-loaderCopy head branch name to clipboard

Conversation

MasterLaplace commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Dec 16, 2024

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(object): obj loader#72
ripel2 merged 28 commits into
mainfrom
40-obj-loader

MasterLaplace commented Dec 9, 2024 •
edited
Loading