refactor(Engine): rename motherclass "Registry" to "Core" - #91
Merged
Miou-zora merged 4 commits intoFeb 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was
linked to
issues
Feb 11, 2025
Closed
Copy link
Copy Markdown
|
Sorry, something went wrong.
ripel2
approved these changes
Feb 11, 2025
ripel2
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a wrapper class for the entt::registry will add a lot of "method redirection", it will make the code a lot bug prone and change a lot of thing in the current codebase. And as it's not useful and important, I think that #89 #90 (maybe later) and #79 should be done right now.