FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update graphql java 24.2 by geichelberger · Pull Request #312 · Enigmatis/graphql-java-annotations · GitHub

/ graphql-java-annotations Public

Update graphql java 24.2 - #312

Closed
geichelberger wants to merge 4 commits into
Enigmatis:masterfrom
geichelberger:update-graphql-java-24.1
ConversationCommits (4)ChecksFiles changed
Closed

Update graphql java 24.2#312
geichelberger wants to merge 4 commits into
Enigmatis:masterfrom
geichelberger:update-graphql-java-24.1

Conversation

geichelberger commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

This updates graphql-java to the latest version 24.1 and tries to fix the breaking changes.

Fgerthoffert commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the PR @geichelberger,

Our current plan is to do a v21.5.1 release, including #310 by @anttip, and then review/merge this PR and release (?).

geichelberger changed the title Update graphql java 24.1 Update graphql java 24.2 Aug 28, 2025

geichelberger commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

I updated the PR as a new graphql-java version was released with a minor bug fix.

This is a small bugfix release, to use the latest version of DataLoader that includes nullability annotation improvements.

https://github.com/graphql-java/graphql-java/releases/tag/v24.2

jkevan commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

Hi @geichelberger
Thank you very much for your contribution! 🙏

Could you please rebase your branch onto the latest main? This will ensure you benefit from the recent CI/workflow fixes and allow the tests to run properly on your PR.

Additionally, could you update the version in gradle.properties to 24.2 instead of 24.1?

Once these changes are made, we should be able to proceed with the approval and merge.
Thanks again for your efforts!

jkevan requested changes Oct 2, 2025
View reviewed changes

jkevan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See previous comment:

  • version in gradle.properties -> 24.2

geichelberger force-pushed the update-graphql-java-24.1 branch from 0ad2b8e to 636db66 Compare October 3, 2025 07:45
geichelberger mentioned this pull request Oct 3, 2025
Merged

jkevan commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

Closing, works done in: #315

jkevan closed this Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jkevan jkevan requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL