FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-1420 Add system where mobs ignore players by CitralFlo · Pull Request #1420 · EternalCodeTeam/EternalCore · GitHub

/ EternalCore Public

GH-1420 Add system where mobs ignore players - #1420

Open
CitralFlo wants to merge 3 commits into
masterfrom
notarget
ConversationCommits (3)ChecksFiles changed
Open

GH-1420 Add system where mobs ignore players#1420
CitralFlo wants to merge 3 commits into
masterfrom
notarget

Conversation

CitralFlo commented Aug 26, 2026

Copy link
Copy Markdown
Member

CitralFlo requested a review from a team as a code owner August 26, 2026 22:19
CitralFlo changed the title Add system where mobs ignore players GH-1420 Add system where mobs ignore players Aug 26, 2026
P1otrulla approved these changes Aug 27, 2026
View reviewed changes

P1otrulla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Bardzo dobra robota! 💯

Zastanawiam się tylko czy nie powinniśmy przenieść tego Interface'a do api (review z tel 👀)

CitralFlo commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

Bardzo dobra robota! 💯

Zastanawiam się tylko czy nie powinniśmy przenieść tego Interface'a do api (review z tel 👀)

Juz jest 🫡 Jeśli coś innego to prośba o doprecyzowanie

Jakubk15 requested changes Aug 27, 2026
View reviewed changes
Comment thread eternalcore-api/src/main/java/com/eternalcode/core/feature/notarget/MobTargetService.java
Comment thread eternalcore-api/src/main/java/com/eternalcode/core/feature/notarget/MobTargetService.java
Comment thread eternalcore-api/src/main/java/com/eternalcode/core/feature/notarget/MobTargetService.java Outdated
Comment thread eternalcore-api/src/main/java/com/eternalcode/core/feature/notarget/MobTargetService.java Outdated
Comment thread eternalcore-core/src/main/java/com/eternalcode/core/feature/notarget/NoTargetCommand.java Outdated
Comment thread ...re-core/src/main/java/com/eternalcode/core/feature/notarget/messages/PLNoTargetMessages.java
@Accessors(fluent = true)
public class PLNoTargetMessages extends OkaeriConfig implements NoTargetMessages {
Notice disabled = Notice.chat("<color:#9d6eef>► <white>Potwory nie będą Cię więcej ignorować!");
Notice enabled = Notice.chat("<color:#9d6eef>► <white>Potwory będą Cię ignorować!");

Jakubk15 Aug 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Notice enabled = Notice.chat("<color:#9d6eef>► <white>Potwory będą Cię ignorować!");
Notice enabled = Notice.chat("<color:#9d6eef>► <white>Potwory będą cię ignorować!");

Comment thread ...re-core/src/main/java/com/eternalcode/core/feature/notarget/messages/PLNoTargetMessages.java
@Getter
@Accessors(fluent = true)
public class PLNoTargetMessages extends OkaeriConfig implements NoTargetMessages {
Notice disabled = Notice.chat("<color:#9d6eef>► <white>Potwory nie będą Cię więcej ignorować!");

Jakubk15 Aug 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Notice disabled = Notice.chat("<color:#9d6eef>► <white>Potwory nie będą Cię więcej ignorować!");
Notice disabled = Notice.chat("<color:#9d6eef>► <white>Potwory nie będą cię więcej ignorować!");

Comment thread eternalcore-core/src/main/java/com/eternalcode/core/feature/notarget/NoTargetCommand.java
Comment thread eternalcore-core/src/main/java/com/eternalcode/core/feature/notarget/NoTargetCommand.java
Comment thread ...alcore-core/src/main/java/com/eternalcode/core/translation/implementation/PLTranslation.java Outdated
CitralFlo and others added 2 commits August 27, 2026 23:07
Update eternalcore-core/src/main/java/com/eternalcode/core/translatio…
5f6fcc6 
…n/implementation/PLTranslation.java

Co-authored-by: Jakub Kędziora <77227023+Jakubk15@users.noreply.github.com>
Follow @Jakubk15 review
cd7e4ab
CitralFlo requested a review from Jakubk15 August 27, 2026 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

P1otrulla P1otrulla approved these changes
vLuckyyy Awaiting requested review from vLuckyyy
Rollczi Awaiting requested review from Rollczi
Pawelusze Awaiting requested review from Pawelusze
Jakubk15 Awaiting requested review from Jakubk15

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL