FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP list accepted talks/proposals by artcz · Pull Request #975 · EuroPython/epcon · GitHub

This repository was archived by the owner on Apr 29, 2022. It is now read-only.
/ epcon Public archive

WIP list accepted talks/proposals - #975

Open
artcz wants to merge 1 commit into
ep2019from
feature/list-accepted-proposals
ConversationCommits (1)ChecksFiles changed
Open

WIP list accepted talks/proposals#975
artcz wants to merge 1 commit into
ep2019from
feature/list-accepted-proposals

Conversation

artcz commented May 20, 2019

Copy link
Copy Markdown
Contributor

No description provided.

artcz requested a review from umgelurgel May 20, 2019 07:49
artcz self-assigned this May 20, 2019
patrick91 approved these changes May 20, 2019
View reviewed changes

patrick91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me :)

Comment thread conference/talks.py
def list_accepted_talks_for_current_conference(request):
"""
"""
# Copy from conference/talk_vorting.py;

patrick91 May 20, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
# Copy from conference/talk_vorting.py;
# Copy from conference/talk_voting.py;

umgelurgel suggested changes May 20, 2019
View reviewed changes

umgelurgel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good - one small comment that would help keep the codebase cleaner - I can help apply the changes.

Also, since it's a new view - could we add some xfailed tests for it?

Comment thread conference/talks.py
"""
"""
# Copy from conference/talk_vorting.py;
# Possibly could be refactored to use some function to come up with filters

umgelurgel May 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since we have the same code in two files, this is definitely a candidate to be refactored.

umgelurgel changed the title list accepted talks/proposals WIP list accepted talks/proposals Nov 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
umgelurgel umgelurgel requested changes
patrick91 patrick91 approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

artcz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL