Publish Dev by EvilBeaver · Pull Request #1621 · EvilBeaver/OneScript · GitHub

Summary by CodeRabbit

Chores
- Updated version naming scheme for release candidate builds.
- Enhanced resource management by ensuring proper cleanup of communication channels when services stop or complete execution.

✏️ Tip: You can customize this high-level summary in your review settings.

Note

Overhauls debugging and symbol binding, adds explicit-import enforcement and deprecation support, refines comparisons and stdlib behavior, upgrades to .NET 8, and removes legacy ASP.NET handler.

Core/Compiler/Runtime:
- Introduce ScopeBindingDescriptor and refactor symbol bindings (ModuleSymbolBinding, JoinedScopes); remove AttachedContext.
- Add explicit-import policy (ExplicitImportsBehavior) with compile-time checks; PackageInfo + IPackageSymbol wiring.
- Add deprecation support (DeprecatedName, warnings/errors for methods/properties/enums).
- Rework comparisons (IBslComparable, ComparisonException); adjust string/date/enum behaviors.
- Upgrade target framework to .NET 8 and modernize configs.
Debugger:
- Replace old controller with session-based IDebugger/IDebugSession; new TCP server, JSON channel, stream utils.
- Add attach/launch flows, wait/nowait, protocol reconciliation; improve error handling/disposal.
StdLib/Language:
- Fix StrReplace on empty search; improve ValueList ToString; sorting and comparer updates; timezone handling via IANA.
- XML: implement ЗаписатьТекущий cases; reader/writer settings tweaks (DTD, declaration handling).
VSCode Adapter/CLI:
- Add waitOnStart, path mapping (pathsMapping), and improved attach; -noWait CLI flag.
Removals:
- Drop legacy ASPNETHandler project and related assets.
Tests/Tooling:
- Extensive new/updated tests (debugger, imports, deprecation, XML, sorting); add cross-platform test runners.

Written by Cursor Bugbot for commit 57a16fe. This will update automatically on new commits. Configure here.

…льного значения

…irective fixes #1545 Разрешено иметь комментарии в строке с директивами аннотации модуля

V2 fix #1542: точное позиционирование места ошибки

…o develop

… в логе

…o develop

…heck-skip Заглушка отсутствующего процесса при Attach из адаптера

…o develop

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The Jenkinsfile's VersionSuffix environment variable is simplified to a constant value 'rc.9', removing dynamic BUILD_NUMBER concatenation. Additionally, the DefaultMessageServer protocol channel is now properly disposed when the message loop completes and when the server stops.

Changes

Cohort / File(s)	Summary
Version Suffix Simplification Jenkinsfile	Removed BUILD_NUMBER concatenation from VersionSuffix environment variable, changing from 'rc.9'+BUILD_NUMBER to constant 'rc.9'
Resource Disposal Pattern src/OneScript.DebugProtocol/TcpServer/DefaultMessageServer.cs	Added explicit disposal of _protocolChannel at the end of RunCommandsLoop thread execution and within Stop() method to ensure proper cleanup

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Verify that the disposal logic in DefaultMessageServer doesn't introduce double-disposal scenarios
Confirm thread safety of _protocolChannel.Dispose() when called from different contexts (RunCommandsLoop and Stop())
Check whether the removal of BUILD_NUMBER from VersionSuffix aligns with intended build versioning strategy

Possibly related PRs

Подготовка к выпуску rc.7 #1550: Removes dynamic BUILD_NUMBER concatenation from Jenkinsfile's VersionSuffix, changing 'rc.X'+BUILD_NUMBER to a constant value
Перевод на net8 #1562: Updates the rc number value in Jenkinsfile's VersionSuffix environment variable while maintaining BUILD_NUMBER concatenation

Poem

🐰 A constant version, now so clean,
No dynamic number jumps between,
The protocol channel bows goodbye,
Disposed with grace as resources fly,
The rabbit hops—all tidy done! 🎉

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check	❓ Inconclusive	The title 'Publish Dev' is vague and does not clearly describe the specific changes made. The PR actually modifies build versioning logic in Jenkinsfile and adds resource disposal in a TCP server class, but the title provides no indication of these substantive changes.	Use a more descriptive title that reflects the main changes, such as 'Remove dynamic BUILD_NUMBER from version suffix' or 'Fix resource disposal in DefaultMessageServer and update build versioning'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Double dispose of channel causes race condition

The _protocolChannel.Dispose() call was added in two locations that can both execute during a Stop() scenario. When Stop() interrupts the thread and disposes the channel, the thread catches the ThreadInterruptedException, exits the while loop, and then also tries to dispose the same channel. The channel implementations (JsonDtoChannel, BinaryChannel) lack double-dispose protection, so this will throw ObjectDisposedException. This also contradicts the class documentation which explicitly states the server does not manage channel lifecycle.

src/OneScript.DebugProtocol/TcpServer/DefaultMessageServer.cs#L116-L117

OneScript/src/OneScript.DebugProtocol/TcpServer/DefaultMessageServer.cs

Lines 116 to 117 in 0d6efd2


	_protocolChannel.Dispose();

src/OneScript.DebugProtocol/TcpServer/DefaultMessageServer.cs#L138-L139

OneScript/src/OneScript.DebugProtocol/TcpServer/DefaultMessageServer.cs

Lines 138 to 139 in 0d6efd2

    
           _messageThread.Interrupt(); 
        
           _protocolChannel.Dispose();

к PR #1584: сортировка строк разных алфавитов

…using

# Conflicts: # src/OneScript.DebugProtocol/TcpServer/DefaultMessageServer.cs

Quality Gate passed

Issues

Measures

Project ID: OneScript

View in SonarQube

Mr-Rm and others added 30 commits May 29, 2025 12:45

fix #1542 : точное позиционирование ошибки

aa145e7

убрано НЕ из бинарных операторов

9217227

уточнение места ошибки препроцессора

65a8d40

опечатки

5b79c11

убран переход к следующему токену и возможное NRE

461e1b8

Исправлены ошибки в сборке

3d4fb17

fix #1552 . Слово Ждать вне асинхронного метода не должно иметь специа…

15d7d8e

…льного значения

Некоторая адаптация под нет8 в части указания фреймворка

6d8e2cb

Разрешено использование комментариев в строке с директивой Использовать

6d0eb1a

Разрешены комментарии после аннотаций модуля

ae53749

Ошибочно вкоммитил net8

5ee6ad0

Исправление ошибки в дженкинсфайле

ca6e382

Merge remote-tracking branch 'origin/develop' into develop

90d26e4

Правка замечания от кролика

d8dfe79

Merge pull request #1553 from EvilBeaver/feature/1545-comment-after-d…

e39dee9

…irective fixes #1545 Разрешено иметь комментарии в строке с директивами аннотации модуля

Просочились неявные юсинги

4999c75

Существенно ускорена компиляция большого числа модулей

6b3bb3d

изменена отметка позиции ошибки

6ebb094

Однократное считывание файла исходника, при регистрации

1a8f0b4

Привнес ошибку, вернул правильный код

28a4a75

Merge pull request #1547 from Mr-Rm/v2/fix-1542

9724e39

V2 fix #1542: точное позиционирование места ошибки

Удалены файлы из LFS

ced957e

Merge branch 'develop' of https://github.com/EvilBeaver/OneScript int…

346ab70

…o develop

NRE при отключении отладки от работающего процесса

ac66f4c

Защита от записи в закрытый канал

b7e4d2a

Отлов исключения при записи события от таргета в закрытый канал

3f99bf2

Конфигурирование лога

5b5dd33

Изменены уровни логов, исправлены исключения при деструктуризации dto…

d347910

… в логе

Обмен версией протокола в части dto

29f61a2

Грязный хак для попытки выяснить тип сериализатора на той стороне

50a9147

EvilBeaver added 11 commits November 30, 2025 17:21

Merge branch 'develop' of https://github.com/EvilBeaver/OneScript int…

4b8a423

…o develop

Правило курсора о версии языка

458a529

fixes #1540 Предупреждение о неявных импортах

9ef7b18

xmldoc для перечисления режима неявных импортов

30e278b

Merge remote-tracking branch 'origin/develop' into develop

0616f4f

Документирован конфиг-файл

e8f22b8

Merge pull request #1613 from Bayselonarrend/featrue/attach-process-c…

ab6cb7f

…heck-skip Заглушка отсутствующего процесса при Attach из адаптера

Новое в версии

376a3f1

Merge branch 'develop' of https://github.com/EvilBeaver/OneScript int…

45fa39d

…o develop

Merge branch 'develop' into feture/publish-dev

cb2171f

Некорректный merge, оставлен ненужный файл.

0d6efd2

EvilBeaver changed the base branch from develop to release/preview December 1, 2025 16:13

cursor Bot reviewed Dec 1, 2025

View reviewed changes

Mr-Rm and others added 2 commits December 1, 2025 23:32

к PR #1584 : сортировка строк разных алфавитов

ee2df24

Merge pull request #1622 from Mr-Rm/v2/fix-1582a

9cb4a62

к PR #1584: сортировка строк разных алфавитов

EvilBeaver force-pushed the feture/publish-dev branch from 35a9078 to 0d6efd2 Compare December 2, 2025 07:36

Merge branch 'develop' into feture/publish-dev

03eb2d4

cursor Bot reviewed Dec 2, 2025

View reviewed changes

Comment thread .github/workflows/copilot-setup-steps.yml

EvilBeaver added 8 commits December 2, 2025 11:16

Исправлено замечание о двойном dispose канала сеанса отладки

ba907e2

Исправлено хамечание об установке версии в копилот

0c77bdd

Удален устаревший метод OnAttach и массово исправлены неиспользуемые …

0301fed

…using

Замечание про отсутствие Equals(object)

804a214

Замечания от Сонара

3c5f0c7

Merge branch 'develop' into feture/publish-dev

39c84f4

# Conflicts: # src/OneScript.DebugProtocol/TcpServer/DefaultMessageServer.cs

Дополнил документацию по pathsMapping

4fd8cdf

Merge branch 'develop' into feture/publish-dev

57a16fe

EvilBeaver merged commit 3ef2cfb into release/preview Dec 2, 2025
4 of 5 checks passed

EvilBeaver deleted the feture/publish-dev branch December 2, 2025 14:12

Publish Dev by EvilBeaver · Pull Request #1621 · EvilBeaver/OneScript · GitHub

Publish Dev - #1621

Publish Dev#1621
EvilBeaver merged 227 commits into
release/previewfrom
feture/publish-dev

EvilBeaver commented Dec 1, 2025 •
edited by cursor Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Dec 1, 2025 •
edited
Loading

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

sonar-openbsl-ru-qa-bot Bot commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Publish Dev by EvilBeaver · Pull Request #1621 · EvilBeaver/OneScript · GitHub

Publish Dev - #1621

Publish Dev#1621EvilBeaver merged 227 commits intorelease/previewEvilBeaver/OneScript:release/previewfrom feture/publish-devEvilBeaver/OneScript:feture/publish-devCopy head branch name to clipboard

Conversation

EvilBeaver commented Dec 1, 2025 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

This PR is being reviewed by Cursor Bugbot

Bug: Double dispose of channel causes race condition

Uh oh!

Uh oh!

sonar-openbsl-ru-qa-bot Bot commented Dec 2, 2025

Quality Gate passed

Issues

Measures

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Publish Dev#1621
EvilBeaver merged 227 commits into
release/previewfrom
feture/publish-dev

EvilBeaver commented Dec 1, 2025 •
edited by cursor Bot
Loading

coderabbitai Bot commented Dec 1, 2025 •
edited
Loading