Use TrimEnd('\0') instead of Replace("\0", "") for null character stripping by Copilot · Pull Request #1650 · EvilBeaver/OneScript · GitHub

Read PR Strip null characters from file paths to fix Windows WebDAV compatibility #1649 conversation and understand the issue
Update PathHelper.cs to use TrimEnd('\0') instead of Replace("\0", "")
Use char (single quotes '\0') instead of string (double quotes "\0")
Update comments to reflect that only trailing null chars are removed
Remove accidentally committed files (opm.ospx, nuget.exe)

Summary

Fixed the issue raised by @Mr-Rm in PR #1649 comments:

Before: path.Replace("\0", "") - removed ALL null characters from path
After: path.TrimEnd('\0') - removes only TRAILING null characters

This is safer because:

Windows WebDAV client adds null chars at the END of paths (trailing)
TrimEnd is more targeted - only fixes the actual issue
Replace could mask security issues like "file.txt\0.exe" where null char hides true extension

Original prompt

Прочитай переписку в #1649 после мержа и поправь замечание

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

…ar handling Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

Replace("\0", "") removes all null characters

@copilot ты не прав. \0 в двойных кавычках же вообще не удаляет null-String, а только бэкслэш с нулем. В отличие от одинарных кавычек

Pull request overview

This PR addresses feedback from PR #1649 by refactoring the null character handling in PathHelper.cs to be more targeted and secure. The change improves the implementation from removing all null characters to removing only trailing null characters.

Changes:

Updated PathHelper.StripNullCharacters() to use TrimEnd('\0') instead of Replace("\0", "")
Changed from string literal "\0" to char literal '\0' for better performance
Enhanced XML documentation to clarify that only trailing null characters are removed and explain the security rationale

Replace("\0", "") removes all null characters

@copilot ты не прав. \0 в двойных кавычках же вообще не удаляет null-String, а только бэкслэш ...

В C# "\0" в строковом литерале — это escape sequence, который представляет null-символ (как и '\0'). Проверил на тесте:

string s = "hello\0world";
Console.WriteLine(s.Replace("\0", "").Length); // 10 (было 11)

Replace("\0", "") действительно удалял null-символы. Но замена на TrimEnd('\0') правильная по другой причине — нужно удалять только trailing nulls, чтобы не маскировать потенциальные атаки типа file.txt\0.exe.

@copilot ты опять закоммитил мусор

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

@copilot ты опять закоммитил мусор

Удалил opm.ospx (commit a0109ea). Теперь в PR только изменение PathHelper.cs.

Quality Gate passed

Issues

Measures

Project ID: OneScript

View in SonarQube

Replace("\0", "") removes all null characters

@copilot ты не прав. \0 в двойных кавычках же вообще не удаляет null-String, а только бэкслэш с нулем. В отличие от одинарных кавычек

По-моему, все-таки удаляет. Или я чего-то не знаю. @nixel2007 откуда инфа, что не удаляет?

@EvilBeaver я спутал, копилот и ты правы

Initial plan

2acd208

Copilot AI assigned Copilot and nixel2007 Jan 22, 2026

Copilot started work on behalf of nixel2007 January 22, 2026 16:52 View session

Copilot AI and others added 4 commits January 22, 2026 16:55

Initial plan for fixing null character handling

8da1507

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Fix: Use TrimEnd('\0') instead of Replace("\0", "") for safer null ch…

90f5f86

…ar handling Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Complete PR with all checks passed

06ff4d9

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Remove accidentally committed nuget.exe

1ac5093

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

nixel2007 marked this pull request as ready for review January 22, 2026 17:00

Copilot AI review requested due to automatic review settings January 22, 2026 17:00

nixel2007 requested review from EvilBeaver and Mr-Rm January 22, 2026 17:00

Copilot AI changed the title [WIP] Fix comments in pull request 1649 Use TrimEnd('\0') instead of Replace("\0", "") for null character stripping Jan 22, 2026

Copilot started reviewing on behalf of nixel2007 January 22, 2026 17:00 View session

Copilot AI requested a review from nixel2007 January 22, 2026 17:01

Copilot finished work on behalf of nixel2007 January 22, 2026 17:01

Copilot started work on behalf of nixel2007 January 22, 2026 17:03 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

bcb5a4f

Copilot finished work on behalf of nixel2007 January 22, 2026 17:07

Copilot started work on behalf of nixel2007 January 22, 2026 17:11 View session

Remove opm.ospx - should not be in repository

a0109ea

Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>

Copilot finished work on behalf of nixel2007 January 22, 2026 17:14

EvilBeaver approved these changes Jan 23, 2026

View reviewed changes

Mr-Rm approved these changes Jan 23, 2026

View reviewed changes

nixel2007 merged commit 8c9206e into develop Jan 23, 2026
3 of 4 checks passed

nixel2007 deleted the copilot/fix-comments-in-pull-request-1649 branch January 23, 2026 16:09

Use TrimEnd('\0') instead of Replace("\0", "") for null character stripping by Copilot · Pull Request #1650 · EvilBeaver/OneScript · GitHub

Use TrimEnd('\0') instead of Replace("\0", "") for null character stripping - #1650

Use TrimEnd('\0') instead of Replace("\0", "") for null character stripping#1650
nixel2007 merged 7 commits into
developfrom
copilot/fix-comments-in-pull-request-1649

Copilot AI commented Jan 22, 2026 •
edited
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Jan 22, 2026

Uh oh!

nixel2007 commented Jan 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI commented Jan 22, 2026

Uh oh!

nixel2007 commented Jan 22, 2026

Uh oh!

Copilot AI commented Jan 22, 2026

Uh oh!

sonar-openbsl-ru-qa-bot Bot commented Jan 22, 2026

Uh oh!

EvilBeaver commented Jan 23, 2026

Uh oh!

nixel2007 commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Use TrimEnd('\0') instead of Replace("\0", "") for null character stripping by Copilot · Pull Request #1650 · EvilBeaver/OneScript · GitHub

Use TrimEnd('\0') instead of Replace("\0", "") for null character stripping - #1650

Use TrimEnd('\0') instead of Replace("\0", "") for null character stripping#1650nixel2007 merged 7 commits intodevelopEvilBeaver/OneScript:developfrom copilot/fix-comments-in-pull-request-1649EvilBeaver/OneScript:copilot/fix-comments-in-pull-request-1649Copy head branch name to clipboard

Conversation

Copilot AI commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai Bot commented Jan 22, 2026

Review skipped

Uh oh!

nixel2007 commented Jan 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI commented Jan 22, 2026

Uh oh!

nixel2007 commented Jan 22, 2026

Uh oh!

Copilot AI commented Jan 22, 2026

Uh oh!

sonar-openbsl-ru-qa-bot Bot commented Jan 22, 2026

Quality Gate passed

Issues

Measures

Uh oh!

EvilBeaver commented Jan 23, 2026

Uh oh!

nixel2007 commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Use TrimEnd('\0') instead of Replace("\0", "") for null character stripping#1650
nixel2007 merged 7 commits into
developfrom
copilot/fix-comments-in-pull-request-1649

Copilot AI commented Jan 22, 2026 •
edited
Loading