fix: support older ffmpeg (libavformat < 59) in cv-reader - #119
Open
bsflll wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Add version check for LIBAVFORMAT_VERSION_MAJOR to handle the const AVCodec* change in av_find_best_stream() between ffmpeg 4.x and 5.x. Ubuntu 22.04 ships ffmpeg 4.4 (libavformat 58.x) which uses AVCodec**, while newer ffmpeg 5.0+ (libavformat 59+) uses const AVCodec**.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cv-reader build fails on Ubuntu 22.04 which ships with ffmpeg 4.4 (libavformat 58.x).
In ffmpeg 5.0+ (libavformat 59+), AVCodec became const-qualified in av_find_best_stream(). This PR adds a version check to support both old and new ffmpeg APIs.
Fixes build error: