Refactored code to make use of interface generics from monaco-editor - #2
Open
bkataru wants to merge 2 commits into
Open
Refactored code to make use of interface generics from monaco-editor#2bkataru wants to merge 2 commits into
bkataru wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…nd added type-guard for inlineCompletionItems
…ts without .ts extensions
andyzg
suggested changes
Feb 7, 2024
andyzg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you for the refactor! Left one comment, and then I can test this and get this merged!
Sorry, something went wrong.
Comment thread
tsconfig.json
| "sourceMap": true, | ||
| "outDir": "dist", | ||
| "moduleResolution": "node", | ||
| "moduleResolution": "Bundler", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
What's the reason for changing the module resolution to Bundler?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored MonacoInlineCompletion into its own file to reuse the class to redefine some interfaces as interface generics in accordance with the monaco-editor API because MonacoInlineCompletion is after all an implementation of the monaco.languages.InlineCompletion interface.
Also added the following type-guard for inlineCompletionItems to remove the type assertion as monaco.languages.InlineCompletion[]