build: Explicit protobuf build version; consistent build/setup deps - #136
Draft
zabarn wants to merge 8 commits into
Draft
build: Explicit protobuf build version; consistent build/setup deps#136zabarn wants to merge 8 commits into
zabarn wants to merge 8 commits into
Conversation
zabarn
marked this pull request as ready for review
September 4, 2024 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Runtime issues were being thrown in projects depending on Feast because of incompatible protobuf and grpcio-tools versions and how they were installed.
This PR forces compatibility between the two by adding them to the setup dependencies, and pins the protobuf version to 4.25.4, which is required by our Go unit tests.
Which issue(s) this PR fixes:
No Jira ticket but follows: feast-dev#4472
Fixes