feat: Redis range query materialization - #309
Open
kpulipati29 wants to merge 4 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Manisha4
reviewed
Nov 7, 2025
Comment thread
sdk/python/feast/infra/online_stores/redis.py
| score = feature_value | ||
| member = redis_key_bin_with_sort_keys | ||
| zset_key = f"{project}:{table.name}:{feature_name}:{redis_key_bin}" | ||
| pipe.zadd(zset_key, {member: score}) |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
I think we should do some validation here to check if the score is numeric type or not rather than wait for Redis to throw the error. What do you think?
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Yes agree, it was in my to-do list. I think we should fail the materialization job if the feature view have multiple sort keys or non numeric types
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materialization changes for Redis range query use cases
Design:
https://expediagroup.atlassian.net/wiki/spaces/PE/pages/438055297
Issue:
https://expediagroup.atlassian.net/browse/EAPC-20219
https://expediagroup.atlassian.net/browse/EAPC-20272