Confluent avro changes - #81
Open
expediamatt wants to merge 29 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…onfluent_avro_changes
…onfluent_avro_changes
…onfluent_avro_changes
…f spark and stream feature view setup to the streaming test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very incomplete PR for https://jira.expedia.biz/browse/EAPC-9716, adding Confluent Avro support to Feast.
My process is iterative based on tests, and I have not been able to test any of this code, so I'm about 100% sure it doesn't work this way. But I am blocked, and this PR is a good basis for working through the block.
The core here is schema_registry.py, which attempts to abstract schema registry client management away from the rest of feast (but will currently require the user to supply all connection urls, certs and secrets themselves), and changes to spark_kafka_processor, which are supposed to process the ConfluentAvro format using the confluent_kafka schema registry client and Avro deserializer.
The ConfluentAvro format is also added throughout the Feast codebase, and some preliminary github actions for spark tests have been copied from existing github actions.