Mysql 8 regex changes and word boundary weirdness branch - #5293
Open
robinsowell wants to merge 1 commit into
Open
Mysql 8 regex changes and word boundary weirdness branch#5293robinsowell wants to merge 1 commit into
robinsowell wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
https://dev.mysql.com/doc/refman/8.0/en/regexp.html Basically? The word boundary changed. Goobering channel entry search param and some pro search code. This adds a helper to juggle that based on mysql version and type- aka maria.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dev.mysql.com/doc/refman/8.0/en/regexp.html
doc change: ExpressionEngine/ExpressionEngine-User-Guide#1149
Basically? The word boundary changed. Goobering channel entry search param and some pro search code. This adds a helper to juggle that based on mysql version and type- aka maria.
User ran into an issue on mysql 8 specifically with /system/ee/legacy/models/channel_model.php and 'Note: MySQL's nutty POSIX regex word boundary is [[:>:]]' which is no longer necessarily true. Also spotted the issue in pro search.
So this:
And added some tests for the above. Need to go make some docs additions to go along with this....