Fix 8.5 deprecations and null joins causing them - #5337
Open
robinsowell wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
left-joined “no related row” data can become a null-id/empty-key related object - and the null throws deprecation warnings. This fix needs good oversight as it may have wider implications. Approach in the fix- when an alias’s primary key is known and the row has NULL for it, skip that alias entirely; when the key is first learned after hydration, do not store or relate the object if getId() is NULL. This removes the phantom relation while still allowing real 0 or non-null IDs to behave normally. Tests have been added, but this changes the data. The implementation now skips null primary-key aliases instead of storing them under an empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
left-joined “no related row” data can become a null-id/empty-key related object - and the null throws deprecation warnings.
This fix needs good oversight as it may have wider implications. Approach in the fix- when an alias’s primary key is known and the row has NULL for it, skip that alias entirely; when the key is first learned after hydration, do not store or relate the object if getId() is NULL. This removes the phantom relation while still allowing real 0 or non-null IDs to behave normally.
Tests have been added, but this changes the data. The implementation now skips null primary-key aliases instead of storing them under an empty string.
See the minimal fix in this pr: #5334
It eliminates the deprecation message and preserves existing behavior (where without the deprecation it treated it as a string) BUT do we really want to preserve that existing behavior? Probably not- which is what this pr does.