FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Xor8: remove previous serialization methods by vprus · Pull Request #52 · FastFilter/fastfilter_java · GitHub

/ fastfilter_java Public

Xor8: remove previous serialization methods - #52

Merged
lemire merged 2 commits into
FastFilter:masterfrom
vprus:cleanup-xor-serialization
Jan 20, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Xor8: remove previous serialization methods#52
lemire merged 2 commits into
FastFilter:masterfrom
vprus:cleanup-xor-serialization

Conversation

vprus commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

The PR #47 added serialization method to the Xor family of filters.

However, Xor8 already had two serialization methods, and they used a different format (without encoded length of the fingerprint array). Having two serialization methods with a different format is just asking for trouble, so this PR
removes the historic method. Test appear to still work.

lemire commented Jan 20, 2026

Copy link
Copy Markdown
Member

@vprus Could you just deprecate it instead ? So we don't break existing code ?

vprus commented Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

I can, but is there evidence this code is used? Xor8 iself is documented as experimental.

lemire commented Jan 20, 2026

Copy link
Copy Markdown
Member

I can, but is there evidence this code is used? Xor8 iself is documented as experimental.

None as far as I can tell, but it is arguably easier to deprecate than to delete. https://www.baeldung.com/java-deprecated

I have just recently added a note to the effect that it is experimental. The implementation is ok, but it is certainly not battle tested.

vprus commented Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

Ok, updated to use @deprecated.

lemire commented Jan 20, 2026

Copy link
Copy Markdown
Member

Yeah. So this is super safe now. We can delete it later after a long time.

lemire merged commit e35ab0d into FastFilter:master Jan 20, 2026
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL