FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test(lint): keep history audits out of CI by zackees · Pull Request #4063 · FastLED/FastLED · GitHub

test(lint): keep history audits out of CI - #4063

Merged
zackees merged 1 commit into
masterfrom
fix/legal-history-tests-skip-ci
Aug 26, 2026
Merged

test(lint): keep history audits out of CI#4063
zackees merged 1 commit into
masterfrom
fix/legal-history-tests-skip-ci

Conversation

zackees commented Aug 26, 2026
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Marks the two repository-history audits ignored by default because they require full Git history and are one-off validation, not CI gates. The audit script explicitly runs both ignored tests. No src changes.\n\nValidation: Rust suite 105 passed, 2 ignored; shell syntax passed.

Summary by CodeRabbit

  • Tests
    • Updated the history audit to use the live Git-history test.
    • The live history test now runs only when explicitly requested.

zackees merged commit f4280c5 into master Aug 26, 2026
28 of 30 checks passed
zackees deleted the fix/legal-history-tests-skip-ci branch August 26, 2026 01:28
fastled-project-sync Bot moved this to Triage in FastLED Tracker Aug 26, 2026

coderabbitai Bot commented Aug 26, 2026
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 08731b2e-4782-4ff4-ab6b-32fe64e950e3

📥 Commits

Reviewing files that changed from the base of the PR and between 234520b and 22148c7.

📒 Files selected for processing (2)
  • ci/lint_cpp_rs/deep_history_audit.sh
  • ci/lint_cpp_rs/src/checkers/file_legal.rs

📝 Walkthrough

Walkthrough

The deep-history audit now invokes live_history. The test is marked ignored and no longer checks repository depth before running.

Changes

Live history audit

Layer / File(s) Summary
Live history test execution
ci/lint_cpp_rs/src/checkers/file_legal.rs, ci/lint_cpp_rs/deep_history_audit.sh
The audit script invokes live_history. The test is ignored and its shallow-repository skip logic was removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches 📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/legal-history-tests-skip-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

fastled-project-sync Bot moved this from Triage to Done in FastLED Tracker Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL