Fixed the name of parameter method_whitelist since it was changed - #96
Open
grisov wants to merge 2 commits into
Open
Fixed the name of parameter method_whitelist since it was changed#96grisov wants to merge 2 commits into
grisov wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
This remains an issue. If you're experiencing this problem, then do this , pending when this is merged. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Hi @grisov, what is blocking the merge of this PR? I am also facing also this issue |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The class urllib3.util.retry.Retry no longer has the method_whitelist parameter. It was renamed to allowed_methods.
From urllib3 documentation:
method_whitelist is deprecated and already removed in latest versions of urllib3.