Remove excessive use of GC via system property - #33
Merged
ianroberts merged 2 commits intoFeb 8, 2024
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Just for interest the automated tests completed almost a minute faster than last time they ran! |
Sorry, something went wrong.
ianroberts
approved these changes
Feb 8, 2024
ianroberts
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM - @johann-petrak any thoughts before we merge this?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Totally fine with this! I think the whole GCing+reporting was from when I wanted to convince people that using this implementation has advantages :D |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide all explicit uses of GC in the code behind a system property. This means in normal usage there won't be a huge slow down due to the GC calls. If you want to profile memory consumption during development then set the system property com.jpetrak.gate.stringannotation.profile to a none null value.