Lesson06 - #887
Open
AlexN-github wants to merge 9 commits into
Open
Lesson06#887AlexN-github wants to merge 9 commits into
AlexN-github wants to merge 9 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Comment thread
lesson06/home_work/hw06_easy.py
|
|
||
| print("Задача-2") | ||
|
|
||
| class ravtrapetc: |
Copy link
Copy Markdown
There was a problem hiding this comment.
имена классам даем в CamelCase стиле
Sorry, something went wrong.
Comment thread
lesson06/home_work/hw06_easy.py
| import math | ||
| len = math.sqrt((self.p2["x"] - self.p1["x"]) ** 2 + (self.p2["y"] - self.p1["y"]) ** 2) | ||
| return len | ||
| self.C = get_len(self.p1,self.p2) |
Copy link
Copy Markdown
There was a problem hiding this comment.
неочень хорошая практика создавть атрибуты класса не в методе init, обратите внимание на то что данве строчки в студии подчеркиваются
Sorry, something went wrong.
Comment thread
lesson06/home_work/hw06_easy.py
Comment on lines
+85
to
+88
| if A1 == A2: | ||
| return True | ||
| else: | ||
| return False |
Copy link
Copy Markdown
There was a problem hiding this comment.
можно просто:
return A1 == A2
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Выполнил все