Drop python 2 and make python 3.8 be the minimum. - #275
Closed
schwehr wants to merge 6 commits into
Closed
schwehr wants to merge 6 commits into
schwehr wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Python 3.7 is end-of-life: https://devguide.python.org/versions/
https://www.python.org/doc/newstyle/ > New-style classes has been integrated into Python 2.7 and old-style classes has been removed in Python 3.
This should let me see the workflow run in my work on my fork.
- Still specify the exact python 3.13 as it is not yet released. - Updated to release candidate 1. 3.13 release is expected in October 2024. - Also fix the more information link. The old one one is dead.
Copy link
Copy Markdown
Contributor
Author
|
Added a bunch more commits and enabled the build.yml workflow on push so I can see the tests run on my branch. All tests work in my branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Removing the patch number of the python versions allowing the workflow to pick newer patch levels of particular python versions, e.g., it was 3.8.18, but now 3.8.19 is being used on my latest commit in my drop-py2 branch: ============================= test session starts ============================== platform linux -- Python 3.8.19, pytest-8.3.2, pluggy-1.[5](https://github.com/schwehr/pyshp/actions/runs/10539369181/job/29202871229#step:6:6).0 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I'm going to close this PR and split things up differently based on some offline discussions. |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.7 is end-of-life:
https://devguide.python.org/versions/