Provide additionalInfo to onLongPressProp - #3065
Open
itsdiay wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
khushal87
suggested changes
Apr 28, 2025
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Hey @deIay, thanks a lot for the PR. There's one thing that has to be taken care of in the PR, and that is the type of the parameter of the onLongPress should be MessagePressableHandlerPayload, same as the onPress, and then you can just add the key as additionalInfo: payload.additionalInfo to the onLongPressArgs object. Currently, this doesn't look correct to me. Let me know if you are not able to figure it out. In that case, I can take it up.
Also, please run the lint checks using yarn lint-fix and build using yarn build so that we don't miss any issues.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
I noticed my custom onLongPressProp wasn't receiving additionalnfo about the press (e.g. specific thumbnail that was long pressed). I want to be able to take action based off the specific thumbnail that was long pressed in my custom onLongPress function. To do this I need access to the additional info objet.
🛠 Implementation details
This change passes the additionalInfo object to prop onLongPress functions.
🎨 UI Changes
iOS🧪 Testing
☑️ Checklist