| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
SDK Size
|
Sorry, something went wrong.
|
🎉 This PR is included in version 9.7.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
🎯 Goal
For some reason, it would appear that video attachments picked from the photo library show no thumbnail when PhotoKit had no cached poster frame for the asset, so the image request fails with PHPhotosErrorDomain 3303 and generation bails. Hits uncached/freshly imported library videos on devic, and always hits videos added to a Simulator via simctl addmedia as an example (which won't immediately generate poster images unless you open the Photos app for example).
🛠 Implementation details
iOS StreamVideoThumbnailGenerator:
Reducing the size of the generated tuhmbnails is considered safe as this was anyway happening with .fastFormat (as mentioned it appears to simply return smaller images rather than play around with downscaling specifically). If anything, it's an increase in quality as from my benchmarks it showed that loading ~200 video thumbnails all at the same time (this is a very pessimistic test of course) rounds out to about ~20MB of extra ram usage. And this is even before taking image optimizations into account, which would alleviate decoding cycles as well. So the quality should be much better while paying almost nothing. So in essence we're basically trying to mimic what .fastFormat does itself but with some extra exploration around it.
🎨 UI Changes
iOS AndroidNo Android changes.
🧪 Testing
☑️ Checklist