This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Fix Learn HTML 003 - Metadata inconsistency and unfinished content - #10285
Open
owyaggy wants to merge 2 commits into
Open
Fix Learn HTML 003 - Metadata inconsistency and unfinished content#10285owyaggy wants to merge 2 commits into
owyaggy wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Fixed inconsistency and incomplete sentence in the last section
rachelandrew
approved these changes
Oct 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed inconsistency and incomplete sentence in the last section of Learn HTML 003 - Metadata
Fixes Issue #10284
Changes proposed in this pull request:
The current instruction about the of the demo website indicates web manifests are a useful tool, but are not under the purview of this module, and as such the element is somewhat long and unwieldy. This tracks with the code block shown at the end of the page.
However, the following paragraph inconsistently states:
It's pretty long, but it's done. It would have been much longer, but you've summed up all the icons, short name, etc. in a manifest file, enabling you to omit many and tags,
Including the sentence fragment - "tags," is the end of a paragraph, so this content is clearly unfinished, as well as inconsistent.
Since web manifests are covered in the PWA series and relevant articles are already linked, it seems the solution is changing this penultimate paragraph of the article to state instead:
"It's pretty long, but it's done."