Adding Google Feedback crash reporting - #77
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
This exclude would be nice to have sooner in a simpler PR
Sorry, something went wrong.
There was a problem hiding this comment.
I've left this soft reference business because I'm cargo culting from IJ and AS source. I don't know why they do it, but I don't know that we shouldn't.
Sorry, something went wrong.
There was a problem hiding this comment.
perhaps relevant: http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4405807
Sorry, something went wrong.
There was a problem hiding this comment.
good find. I'll file an issue to verify this with jetbrains and fix broadly across our resource bundles
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, something went wrong.
|
Forgot to mention this CL is ready for re-review. |
Sorry, something went wrong.
There was a problem hiding this comment.
I think you just need to catch IOException here, or maybe IOException + RuntimeException
Sorry, something went wrong.
There was a problem hiding this comment.
fixing
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
Adding Google Feedback crash reporting
This commit allows users to report errors caused by our plugin using Google Feedback crash reporting.
To share crash reporting across the login and core plugins I created a new generic java module called common-lib.
Ideally the plain java module would use Gradle sync, but I haven't found a way to get intellij to only sync that one module so it's manually configured for now.
I've updated our plugin build to include transitive deps of common-lib. This is a bit of a pain. Ideally the full transitive closure of runtime deps would be packaged into the plugin automatically. Another thing to study should we go down the path of building a gradle plugin specifically for intellij plugin project types.