Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
could we conditionally add this for Android Studio? http://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/plugin_compatibility.html
Sorry, something went wrong.
There was a problem hiding this comment.
What would be the module name we'd key off of to find out if we're inside android studio?
Sorry, something went wrong.
There was a problem hiding this comment.
based off of the same jetbrains doc page it looks like it's:
com.intellij.modules.androidstudio
On Tue, Sep 29, 2015 at 11:24 AM, Elliotte Rusty Harold <
notifications@github.com> wrote:
In core-plugin/src/META-INF/plugin.xml
#83 (comment)
:@@ -126,11 +126,6 @@
- <action id="GoogleCloudTools.DeployToAppEngine"
What would be the module name we'd key off of to find out if we're inside
android studio?—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/83/files#r40686167
.
Sorry, something went wrong.
There was a problem hiding this comment.
done
Sorry, something went wrong.
There was a problem hiding this comment.
argh. I didn't think we'd have to do all this. Does this show up as a separate plugin? Did you try just including a fargment?
Sorry, something went wrong.
There was a problem hiding this comment.
Per Jetbrains:
<!-- Optional dependency on another plugin. If the plugin with the "MySecondPlugin" ID is installed, the contents of mysecondplugin.xml (the format of this file conforms to the format of plugin.xml) will be loaded. --> <depends optional="true" config-file="mysecondplugin.xml">MySecondPlugin</depends>
Sorry, something went wrong.
There was a problem hiding this comment.
link? The previous docs make it sound like an extension to the existing
plugin:
You can also specify optional module dependencies. If your plugin works
with all products but provides some Java-specific functionality, you can
use a dependency tag like this:
On Tue, Sep 29, 2015 at 3:46 PM, Elliotte Rusty Harold <
notifications@github.com> wrote:
In core-plugin/src/META-INF/android-studio-features.xml
#83 (comment)
:@@ -0,0 +1,22 @@
+
- Google Cloud Tools Deploy To Apop Engine
Per Jetbrains:
MySecondPlugin
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/83/files#r40719402
.
Sorry, something went wrong.
There was a problem hiding this comment.
http://www.jetbrains.org/intellij/sdk/docs/basics/plugin_structure/plugin_configuration_file.html
I agree this isn't perfectly clear. How shoudl we test it?
Sorry, something went wrong.
There was a problem hiding this comment.
Build the plugin and install it into Android Studio?
http://developer.android.com/tools/studio/index.html
On Tue, Sep 29, 2015 at 4:43 PM, Elliotte Rusty Harold <
notifications@github.com> wrote:
In core-plugin/src/META-INF/android-studio-features.xml
#83 (comment)
:@@ -0,0 +1,22 @@
+
- Google Cloud Tools Deploy To Apop Engine
http://www.jetbrains.org/intellij/sdk/docs/basics/plugin_structure/plugin_configuration_file.html
I agree this isn't perfectly clear. How shoudl we test it?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/83/files#r40726527
.
Sorry, something went wrong.
There was a problem hiding this comment.
It may or may not overwrite the existing plugin. That in itself will be a
learning experience.
On Tue, Sep 29, 2015 at 5:10 PM, Patrick Flynn paflynn@google.com wrote:
Build the plugin and install it into Android Studio?
http://developer.android.com/tools/studio/index.htmlOn Tue, Sep 29, 2015 at 4:43 PM, Elliotte Rusty Harold <
notifications@github.com> wrote:In core-plugin/src/META-INF/android-studio-features.xml
#83 (comment)
:@@ -0,0 +1,22 @@
+
- Google Cloud Tools Deploy To Apop Engine
http://www.jetbrains.org/intellij/sdk/docs/basics/plugin_structure/plugin_configuration_file.html
I agree this isn't perfectly clear. How shoudl we test it?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/83/files#r40726527
.
Sorry, something went wrong.
There was a problem hiding this comment.
So it appears neither this nor the approach where we jus tput the action into android-studio-features works. Both fail to load in AS. :-(
Sorry, something went wrong.
There was a problem hiding this comment.
Let's just remove it from the plugin.xml for now. We've already agreed we
want to move all of this out from core into our AS plugin anyway.
On Wed, Sep 30, 2015 at 3:46 PM, Elliotte Rusty Harold <
notifications@github.com> wrote:
In core-plugin/src/META-INF/android-studio-features.xml
#83 (comment)
:@@ -0,0 +1,22 @@
+
- Google Cloud Tools Deploy To Apop Engine
So it appears neither this nor the approach where we jus tput the action
into android-studio-features works. Both fail to load in AS. :-(—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/83/files#r40841869
.
Sorry, something went wrong.
* make sure kotlin plugin version takes precedence.
@patflynn @nbashirbello