feat(secretmanager): Add secret rotation samples by khilan-crest · Pull Request #3296 · GoogleCloudPlatform/dotnet-docs-samples · GitHub

Add secret rotation samples

…lan-crest/dotnet-docs-samples into cs_filter_cmek_samples

…est/dotnet-docs-samples into cs_expiretime_samples

…st/dotnet-docs-samples into cs_tag_samples

Here is the summary of changes.

You are about to add 29 region tags.

secretmanager/api/SecretManager.Samples/BindTagToRegionalSecret.cs:17, tag secretmanager_bind_tags_to_regional_secret
secretmanager/api/SecretManager.Samples/BindTagToSecret.cs:17, tag secretmanager_bind_tags_to_secret
secretmanager/api/SecretManager.Samples/CreateRegionalSecretWithExpiration.cs:17, tag secretmanager_create_regional_secret_with_expire_time
secretmanager/api/SecretManager.Samples/CreateRegionalSecretWithRotation.cs:17, tag secretmanager_create_regional_secret_with_rotation
secretmanager/api/SecretManager.Samples/CreateRegionalSecretWithTopic.cs:17, tag secretmanager_create_regional_secret_with_topic
secretmanager/api/SecretManager.Samples/CreateSecretWithExpiration.cs:17, tag secretmanager_create_secret_with_expiration
secretmanager/api/SecretManager.Samples/CreateSecretWithRotation.cs:17, tag secretmanager_create_secret_with_rotation
secretmanager/api/SecretManager.Samples/CreateSecretWithTopic.cs:17, tag secretmanager_create_secret_with_topic
secretmanager/api/SecretManager.Samples/DeleteRegionalSecretAnnotation.cs:17, tag secretmanager_delete_regional_secret_annotation
secretmanager/api/SecretManager.Samples/DeleteRegionalSecretExpiration.cs:17, tag secretmanager_delete_regional_secret_expiration
secretmanager/api/SecretManager.Samples/DeleteRegionalSecretLabel.cs:17, tag secretmanager_delete_regional_secret_label
secretmanager/api/SecretManager.Samples/DeleteRegionalSecretRotation.cs:17, tag secretmanager_delete_regional_secret_rotation
secretmanager/api/SecretManager.Samples/DeleteSecretAnnotation.cs:17, tag secretmanager_delete_secret_annotation
secretmanager/api/SecretManager.Samples/DeleteSecretExpiration.cs:17, tag secretmanager_delete_secret_expiration
secretmanager/api/SecretManager.Samples/DeleteSecretLabel.cs:17, tag secretmanager_delete_secret_label
secretmanager/api/SecretManager.Samples/DeleteSecretRotation.cs:17, tag secretmanager_delete_secret_rotation
secretmanager/api/SecretManager.Samples/DetachRegionalTagBinding.cs:17, tag secretmanager_detach_tag_from_regional_secret
secretmanager/api/SecretManager.Samples/DetachTagBinding.cs:17, tag secretmanager_detach_tag
secretmanager/api/SecretManager.Samples/EditSecretLabel.cs:17, tag secretmanager_edit_secret_label
secretmanager/api/SecretManager.Samples/ListRegionalTagBindings.cs:17, tag secretmanager_list_regional_secret_tag_bindings
secretmanager/api/SecretManager.Samples/ListSecretVersionsWithFilter.cs:17, tag secretmanager_list_secret_versions_with_filter
secretmanager/api/SecretManager.Samples/ListSecretsWithFilter.cs:17, tag secretmanager_list_secrets_with_filter
secretmanager/api/SecretManager.Samples/ListTagBindings.cs:17, tag secretmanager_list_tag_bindings
secretmanager/api/SecretManager.Samples/UpdateRegionalSecretExpiration.cs:17, tag secretmanager_update_regional_secret_expiration
secretmanager/api/SecretManager.Samples/UpdateRegionalSecretRotation.cs:17, tag secretmanager_update_regional_secret_rotation_period
secretmanager/api/SecretManager.Samples/UpdateSecretExpiration.cs:17, tag secretmanager_update_secret_expiration
secretmanager/api/SecretManager.Samples/UpdateSecretRotation.cs:17, tag secretmanager_update_secret_rotation
secretmanager/api/SecretManager.Samples/createRegionalSecretWithCmek.cs:17, tag secretmanager_create_regional_secret_with_cmek
secretmanager/api/SecretManager.Samples/createSecretWithCmek.cs:17, tag secretmanager_create_secret_with_cmek

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

Summary of Changes

Hello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the C# client library for Google Cloud Secret Manager by introducing a wide array of new code samples. These samples aim to provide developers with clear, practical examples for advanced secret management functionalities, including automated secret rotation, time-based expiration, integration with resource tags for better organization, and the use of Customer-Managed Encryption Keys for enhanced security. The additions also cover improved secret discoverability through filtered listing operations and comprehensive metadata management.

Highlights

New Secret Management Samples: A comprehensive suite of C# samples has been added for Google Cloud Secret Manager, covering various secret lifecycle and metadata management operations.
Secret Rotation and Expiration: New samples demonstrate how to create, update, and delete secret rotation and expiration configurations for both global and regional secrets.
Tag Management: Examples are included for binding, detaching, and listing tags associated with secrets, supporting both global and regional contexts.
Filtering and Metadata: Samples for listing secret versions with filters (e.g., by state) and listing secrets with filters (e.g., by labels) are now available.
Customer-Managed Encryption Keys (CMEK): Samples for creating secrets with Customer-Managed Encryption Keys (CMEK) are added, for both global and regional deployments.
Metadata Deletion: Implemented samples for managing secret metadata, specifically for deleting annotations and labels.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Code Review

This pull request adds a comprehensive set of samples and tests for secret rotation and related features in Secret Manager. The additions are valuable. However, there are several critical issues in the tests that need to be addressed:

Many of the new tests rely on helper methods in the test fixtures (e.g., CreateSecretWithExpireTime, CreateSecretWithRotation) which have not been implemented. This will cause compilation failures. These helper methods need to be added to SecretManagerFixture and RegionalSecretManagerFixture.
Several tests create resources (secrets, tags) but fail to clean them up, which will lead to resource leaks in the test project.
There's a bug in DeleteSecretExpirationTests where the wrong secret is deleted.
A few other minor issues like incorrect logging, exception handling, and filename mismatches are also present.

I've added specific comments on the relevant files. Addressing these issues will improve the correctness and reliability of the new samples and tests.

…est/dotnet-docs-samples into cs_expiretime_samples

…st/dotnet-docs-samples into cs_tag_samples

…et-docs-samples into cs_rotation_samples

…lan-crest/dotnet-docs-samples into cs_filter_cmek_samples

…est/dotnet-docs-samples into cs_expiretime_samples

…lan-crest/dotnet-docs-samples into cs_filter_cmek_samples

…est/dotnet-docs-samples into cs_expiretime_samples

…st/dotnet-docs-samples into cs_tag_samples

…et-docs-samples into cs_rotation_samples

khilan-crest added 13 commits January 22, 2026 15:12

feat(secretmanager): Adding labels and annotations sample

62f68ac

feat(secretmanager): Adding filter and cmek samples

0b20481

feat(secretmanager): Adding secret version filter samples

dee8bc1

feat(secretmanager): Adding secrets tags samples

a888e11

feat(secretmanager): Adding secrets expiration samples

d21d2a7

feat(secretmanager): Update labels annotations samples

5832e34

feat(secretmanager): Update cmek filter samples

7b77ac3

Merge branch 'cs_labels_annotation_samples' of https://github.com/khi…

e4fe6a0

…lan-crest/dotnet-docs-samples into cs_filter_cmek_samples

Merge branch 'cs_filter_cmek_samples' of https://github.com/khilan-cr…

43f47dd

…est/dotnet-docs-samples into cs_expiretime_samples

feat(secretmanager): Update expiration samples

922ff50

Merge branch 'cs_expiretime_samples' of https://github.com/khilan-cre…

e02e8ed

…st/dotnet-docs-samples into cs_tag_samples

feat(secretmanager): Update tags samples

68b3c11

feat(secretmanager): Add secret rotation samples

d410f73

khilan-crest requested review from a team as code owners January 28, 2026 07:30

product-auto-label Bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jan 28, 2026

blunderbuss-gcf Bot assigned cy-yun and YashSaraf11 Jan 28, 2026

gemini-code-assist Bot reviewed Jan 28, 2026

View reviewed changes

khilan-crest added 8 commits January 28, 2026 15:33

feat(secretmanager): Updating fixture

cdd5217

Merge branch 'cs_filter_cmek_samples' of https://github.com/khilan-cr…

3933710

…est/dotnet-docs-samples into cs_expiretime_samples

feat(secretmanager): Updating fixture

2b756f1

Merge branch 'cs_expiretime_samples' of https://github.com/khilan-cre…

1d82a7d

…st/dotnet-docs-samples into cs_tag_samples

Merge branch 'cs_tag_samples' of https://github.com/khilan-crest/dotn…

02390e8

…et-docs-samples into cs_rotation_samples

feat(secretmanager): Updating fixture

d2cfa81

feat(secretmanager): Reformat code

4641d03

Merge branch 'cs_labels_annotation_samples' of https://github.com/khi…

cdbc3c2

…lan-crest/dotnet-docs-samples into cs_filter_cmek_samples

khilan-crest added 10 commits January 28, 2026 18:00

feat(secretmanager): Reformat code

34e7a7a

Merge branch 'cs_filter_cmek_samples' of https://github.com/khilan-cr…

32295a4

…est/dotnet-docs-samples into cs_expiretime_samples

feat(secretmanager): Reformat code

5a4e75a

feat(secretmanager): Reformat code

2f0bfb5

Merge branch 'cs_labels_annotation_samples' of https://github.com/khi…

7dea915

…lan-crest/dotnet-docs-samples into cs_filter_cmek_samples

Merge branch 'cs_filter_cmek_samples' of https://github.com/khilan-cr…

a24afb7

…est/dotnet-docs-samples into cs_expiretime_samples

feat(secretmanager): Reformat code

033b2a6

feat(secretmanager): Reformat code

2c1de99

Merge branch 'cs_expiretime_samples' of https://github.com/khilan-cre…

9e8e2f4

…st/dotnet-docs-samples into cs_tag_samples

Merge branch 'cs_tag_samples' of https://github.com/khilan-crest/dotn…

8c8e8b4

…et-docs-samples into cs_rotation_samples

amanda-tarafa unassigned cy-yun Jan 28, 2026

khilan-crest added 6 commits January 29, 2026 10:36

feat(secretmanager): Reformat code

26f4e0e

Merge branch 'cs_tag_samples' of https://github.com/khilan-crest/dotn…

c2015d4

…et-docs-samples into cs_rotation_samples

feat(secretmanager): Reformat code

4f00ed3

feat(secretmanager): Reformat code

5bea92e

feat(secretmanager): Reformat code

eced0ba

Merge branch 'cs_tag_samples' of https://github.com/khilan-crest/dotn…

61a4496

…et-docs-samples into cs_rotation_samples

feat(secretmanager): Add secret rotation samples by khilan-crest · Pull Request #3296 · GoogleCloudPlatform/dotnet-docs-samples · GitHub

Uh oh!

feat(secretmanager): Add secret rotation samples - #3296

feat(secretmanager): Add secret rotation samples#3296
khilan-crest wants to merge 37 commits into
GoogleCloudPlatform:mainfrom
khilan-crest:cs_rotation_samples

khilan-crest commented Jan 28, 2026

Uh oh!

snippet-bot Bot commented Jan 28, 2026 •
edited
Loading

Uh oh!

Uh oh!

gemini-code-assist Bot commented Jan 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(secretmanager): Add secret rotation samples by khilan-crest · Pull Request #3296 · GoogleCloudPlatform/dotnet-docs-samples · GitHub

Uh oh!

feat(secretmanager): Add secret rotation samples - #3296

feat(secretmanager): Add secret rotation samples#3296khilan-crest wants to merge 37 commits intoGoogleCloudPlatform:mainGoogleCloudPlatform/dotnet-docs-samples:mainfrom khilan-crest:cs_rotation_sampleskhilan-crest/dotnet-docs-samples:cs_rotation_samplesCopy head branch name to clipboard

Conversation

khilan-crest commented Jan 28, 2026

Uh oh!

snippet-bot Bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Jan 28, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(secretmanager): Add secret rotation samples#3296
khilan-crest wants to merge 37 commits into
GoogleCloudPlatform:mainfrom
khilan-crest:cs_rotation_samples

snippet-bot Bot commented Jan 28, 2026 •
edited
Loading