Replace python-jose with google alternative - #566
Conversation
Sorry, something went wrong.
Removing the insecure python-jose package
|
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Sorry, something went wrong.
|
@Jipje thanks for raising this and investigating a solution /gcbrun |
Sorry, something went wrong.
|
Cheers @iennae, happy to help out. I am unable to view the details of the kokoro build so am unsure as to why it fails. Is it anything to do with the adjusted # [START getting_started_auth_certs] comments? |
Sorry, something went wrong.
| AUDIENCE = None | ||
|
|
||
|
|
||
| # [START getting_started_auth_certs] |
There was a problem hiding this comment.
@Jipje can you let me know about why you're removing this block here? Thanks.
Sorry, something went wrong.
There was a problem hiding this comment.
(I answered my own question. I need to fix some stuff in documentation because removing this block will break a page. )
Sorry, something went wrong.
don't create a conflict with pre-existing region tags; ensure that existing region tag doesn't break here
Reviewers
At least 1 approving review is required to merge this pull request.
Closes #565
For more context to why python-jose should be replaced, please reference #565
This solution is a modified version of another repository of GoogleCloudPlatform: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/iap/validate_jwt.py. Although the code was modified as to minimize the amount of changes necessary in this repository.
The certs() method and CERTS global have been replaced by a certs_url parameter in the verify_token method. This did not change behaviour in the tests.