FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Simplify setup for the ide-target-platform by briandealwis · Pull Request #2017 · GoogleCloudPlatform/google-cloud-eclipse · GitHub

/ google-cloud-eclipse Public

Simplify setup for the ide-target-platform - #2017

Open
briandealwis wants to merge 2 commits into
masterfrom
idetp
ConversationCommits (2)ChecksFiles changed
Open

Simplify setup for the ide-target-platform#2017
briandealwis wants to merge 2 commits into
masterfrom
idetp

Conversation

briandealwis commented Jun 7, 2017

Copy link
Copy Markdown
Member

No description provided.

briandealwis requested a review from elharo June 7, 2017 15:21
elharo reviewed Jun 7, 2017
View reviewed changes
Comment thread README.md
`$ (cd eclipse; mvn package)`

1. Open the `Preferences` dialog, go to `Plug-in Development` > `Target Platform`.
1. Open the `ide-target-platform/gcp-ide-target-platform.target` file.

elharo Jun 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't see this path in the project explorer?

briandealwis Jun 7, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, I should have mentioned this: I renamed the eclipse/ide-target-platform project to just ide-target-platform. The Maven artifactID was previously ide-target-platform.repo and the .project had maven-dependencies. You may need to delete the maven-dependencies and/or ide-target-platform.repo projects and re-import them as existing projects.

codecov-io commented Jun 7, 2017 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2017 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2017   +/-   ##
=========================================
  Coverage     66.06%   66.06%           
  Complexity     1864     1864           
=========================================
  Files           322      322           
  Lines         12534    12534           
  Branches       1137     1137           
=========================================
  Hits           8281     8281           
  Misses         3828     3828           
  Partials        425      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9359fca...d4a7864. Read the comment docs.

briandealwis commented Jun 7, 2017

Copy link
Copy Markdown
Member Author

Oh, this is why we don't use directory- or installation-based targets: https://bugs.eclipse.org/bugs/show_bug.cgi?id=501617

elharo previously approved these changes Jun 7, 2017
View reviewed changes
briandealwis dismissed elharo’s stale review June 8, 2017 20:55

Need to see if I can work around this JUnit issue.

briandealwis commented Dec 15, 2017

Copy link
Copy Markdown
Member Author

This is blocked on support for pulling the JUnit jars from unexploded bundles (Eclipse bug 501617). This has been fixed in Photon 4.8 M4.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
elharo elharo left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

blocked cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL