FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Endpoints Auth Between Services by daniel-sanche · Pull Request #1330 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

Endpoints Auth Between Services - #1330

Merged
daniel-sanche merged 15 commits into
GoogleCloudPlatform:masterfrom
daniel-sanche:endpoints-auth
Feb 8, 2019
ConversationCommits (15)ChecksFiles changed
Merged

Endpoints Auth Between Services#1330
daniel-sanche merged 15 commits into
GoogleCloudPlatform:masterfrom
daniel-sanche:endpoints-auth

Conversation

daniel-sanche commented Feb 7, 2019

Copy link
Copy Markdown
Member

Adding java samples for endpoints auth between services

related to b/109951097 and cl/228405078

daniel-sanche requested a review from a team February 7, 2019 01:31
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2019
kurtisvg suggested changes Feb 8, 2019
View reviewed changes

kurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There are also likely several style violations that checkstyle will check when the parent pom is added.

Comment thread endpoints/getting-started/clients/pom.xml
Comment thread endpoints/getting-started/clients/src/main/java/com/example/app/JWTClient.java Outdated
Comment thread endpoints/getting-started/clients/src/main/java/com/example/app/JWTClient.java Outdated
Comment thread endpoints/getting-started/clients/src/main/java/com/example/app/JWTClient.java Outdated
Comment thread endpoints/getting-started/clients/src/main/java/com/example/app/JWTClient.java Outdated

daniel-sanche commented Feb 8, 2019

Copy link
Copy Markdown
Member Author

@kurtisvg I addressed your comments, let me know if there's anything else

kurtisvg commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@dansanche Just needs a test for the two snippets, then LGTM

daniel-sanche commented Feb 8, 2019

Copy link
Copy Markdown
Member Author

The issue with testing these is that it requires an endpoints backed to be deployed for it to work as intended. If you think it's necessary, I could test the jwt creation function in isolation, but it feels like that would be more a test of the jwt/cyptography libraries I'm using rather than the sample itself

kurtisvg commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

No, that seems like a reasonable explanation.

daniel-sanche merged commit 7bfc2ff into GoogleCloudPlatform:master Feb 8, 2019
daniel-sanche deleted the endpoints-auth branch February 8, 2019 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
kurtisvg kurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL