Fix listening on port 8080 Warning - #1511
Merged
kurtisvg merged 14 commits intoJul 16, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Uses the PORT environment variable when is present, otherwise sets 8080.
kurtisvg
suggested changes
Jul 16, 2019
kurtisvg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Not sure this change is warranted. I think AppEngine always wants port 8080?
@averikitsch - thoughts?
Sorry, something went wrong.
Comment thread
...a11/appengine-simple-jetty-main/src/main/java/com/example/appengine/demo/jettymain/Main.java
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@kurtisvg I did this to prevent this warning in the console logs viewer : {
insertId: "5d26aeb2000c973148c895ec"
labels: {
clone_id: "00c61b117c21f3d5d43e23db86e8c2c0964ad67598aa0959da791ccdd718816044908044adf3"
}
logName: "projects/calculadora-sat/logs/stderr"
receiveTimestamp: "2019-07-11T03:36:18.833405023Z"
resource: {
labels: {
module_id: "default"
project_id: "calculadora-sat"
version_id: "north"
zone: "us17"
}
type: "gae_app"
}
severity: "WARNING"
textPayload: "App is listening on port 8080, it should instead listen on the port defined by the PORT environment variable. As a consequence, nginx cannot be started. Performance may be degraded. Please listen on the port defined by the PORT environment variable."
timestamp: "2019-07-11T03:36:18.825137Z"
}
And I will update the code, following your recommendations. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@kurtisvg this must be a new warning. The app is suppose to be listening to port 8080. (This error sounds more like a Cloud Run error). I will check in the the GAE team. |
Sorry, something went wrong.
kurtisvg
reviewed
Jul 16, 2019
Comment thread
...a11/appengine-simple-jetty-main/src/main/java/com/example/appengine/demo/jettymain/Main.java
Outdated
…/example/appengine/demo/jettymain/Main.java Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
kurtisvg
reviewed
Jul 16, 2019
Comment thread
appengine-java11/custom-entrypoint/Main.java
Outdated
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
kurtisvg
approved these changes
Jul 16, 2019
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [3.6.7](googleapis/java-dlp@v3.6.6...v3.6.7) (2022-08-05) ### Documentation * **owlbot-java:** explaining why not using formatter in pom.xml ([#1511](https://github.com/googleapis/java-dlp/issues/1511)) ([#945](googleapis/java-dlp#945)) ([ab8d91f](googleapis/java-dlp@ab8d91f)), closes [#1502](https://github.com/googleapis/java-dlp/issues/1502) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the application is deployed with hard-coded port configuration, appear the Warning:
'App is listening on port 8080, it should instead listen on the port defined by the PORT environment variable.'
This patch look for the PORT environment variable, otherwise set 8080.