FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add missing samples for classification and rename object detection sa… by nnegrey · Pull Request #1604 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

Add missing samples for classification and rename object detection sa… - #1604

Merged
nnegrey merged 4 commits into
masterfrom
automl-vision-classification
Oct 21, 2019
ConversationCommits (4)ChecksFiles changed
Merged

Add missing samples for classification and rename object detection sa…#1604
nnegrey merged 4 commits into
masterfrom
automl-vision-classification

Conversation

nnegrey commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

…mple to add clarification

nnegrey requested a review from a team October 7, 2019 20:53
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2019
nnegrey assigned lesv and unassigned dzlier-gcp Oct 8, 2019

nnegrey commented Oct 8, 2019

Copy link
Copy Markdown
Contributor Author

Looking into why these tests are failing.
Might be because there is only 1 model to deploy and both are trying to deploy it at the same time.

shuesc1 commented Oct 8, 2019

Copy link
Copy Markdown

Reminder to ping me when merging these branch samples to master to update official documentation.

lesv reviewed Oct 9, 2019
View reviewed changes

lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should there be changes to a README for this?

nnegrey commented Oct 9, 2019

Copy link
Copy Markdown
Contributor Author

I'm not sure, since we don't have main methods anymore, do we still expect them to be in a README?

GoogleCloudPlatform deleted a comment Oct 21, 2019
GoogleCloudPlatform deleted a comment Oct 21, 2019
GoogleCloudPlatform deleted a comment Oct 21, 2019
GoogleCloudPlatform deleted a comment Oct 21, 2019
GoogleCloudPlatform deleted a comment Oct 21, 2019
nnegrey merged commit 82790c1 into master Oct 21, 2019

nnegrey commented Oct 21, 2019

Copy link
Copy Markdown
Contributor Author

Samples published.
Deleting branch.

nnegrey deleted the automl-vision-classification branch October 21, 2019 21:25
GoogleCloudPlatform deleted a comment Oct 22, 2019
GoogleCloudPlatform deleted a comment Oct 22, 2019
GoogleCloudPlatform deleted a comment Oct 22, 2019
GoogleCloudPlatform deleted a comment Oct 22, 2019
GoogleCloudPlatform locked as resolved and limited conversation to collaborators Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
lesv lesv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

lesv

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL