Automl translation ga by nnegrey · Pull Request #1614 · GoogleCloudPlatform/java-docs-samples · GitHub

No description provided.

…ples

Java 8 is failing.

LGTM - Nits that annoy only me, but do at least read them.

should this be using got instead? perhaps using an intermediate form?

Oops, yep.
Simplified to: datasetId = got.split("Dataset id: ")[1].split("\n")[0];

ok, but shouldn't this be more efficient on 2 lines?

Realized I can simplify it to: modelId = got.split("Model id: ")[1].split("\n")[0];

Perhaps this should use an intermediate variable?

ok, but could you clean this up a bit and teach something here?

ok, but could you clean this up a bit and teach something here? Why do I see the same code in two places?

The create, get, list for both datasets and models are all very similar.

ok, but could you clean this up a bit and teach something here?

Would something like this be good?

      // To get the dataset id, you have to parse it out of the `name` field. As dataset Ids are
      // required for other methods.
      // Name Form: `projects/{project_id}/locations/{location_id}/datasets/{dataset_id}`
      int lastIndex = createdDataset.getName().split("/").length - 1;
      String datasetId = createdDataset.getName().split("/")[lastIndex];
      System.out.format("Dataset id: %s\n", datasetId);

I was thinking more like:

String[] names = createdDataset.getName().split("/");
String datasetId = names[names.length - 1];

👍 I will probably keep the comment in there too.

Thanks -- I'm happy w/ this, though I ran across https://stackoverflow.com/a/15317034/738710 which sadly has a better answer. No need to use it, but for the future:
String retrievedDatasetId = dataset.getName().substring( sentence.lastIndexOf("/") + 1);

BTW - Java 8 is failing.

Ah, I see why. That's the old beta files.
I have a PR to fix those tests: #1606

…dPlatform/java-docs-samples into automl-translation-ga

DO_NOT_DELETE BRANCH
TODO: Update docs samples to master branch
TODO: Move samples to refactored location

Files moved to: #1621

* Convert samples to new style guides and update to GA. Add missing samples * Update samples and tests * Update ExportDataset.java * Update Prediction.java * Update based on feedback * Update ListOperationStatus.java * Update ID of test dataset * Lint: Update License header and import order

nnegrey and others added 4 commits October 9, 2019 22:08

Convert samples to new style guides and update to GA. Add missing sam…

f7b283b

…ples

Update samples and tests

da78636

Update ExportDataset.java

a30231c

Update Prediction.java

0d6bd4e

nnegrey requested a review from a team October 14, 2019 20:23

blunderbuss-gcf Bot assigned lesv Oct 14, 2019

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2019

Merge branch 'master' into automl-translation-ga

882d234

lesv approved these changes Oct 14, 2019

View reviewed changes

nnegrey and others added 2 commits October 16, 2019 09:58

Update based on feedback

3609abf

Update ListOperationStatus.java

e0c5971

lesv reviewed Oct 16, 2019

View reviewed changes

lesv approved these changes Oct 16, 2019

View reviewed changes

Merge branch 'master' into automl-translation-ga

6387c27

nnegrey and others added 4 commits October 16, 2019 15:14

Update ID of test dataset

15f8778

Merge branch 'automl-translation-ga' of https://github.com/GoogleClou…

1885149

…dPlatform/java-docs-samples into automl-translation-ga

Lint: Update License header and import order

142fc96

Merge branch 'master' into automl-translation-ga

f8350d9

nnegrey merged commit 6423b40 into master Oct 17, 2019

kurtisvg deleted the automl-translation-ga branch November 15, 2019 21:36

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-automl #7444

Merged

9 tasks

+                  // LIST MODELS
+                  ListModels.listModels(PROJECT_ID);
+                  String got = bout.toString();
+                  modelId = got.split("\n")[1].split("/")[got.split("\n")[1].split("/").length - 1];

+                      // Display the model information.
+                      System.out.format("Model name: %s\n", model.getName());
+                      System.out.format(
+                          "Model id: %s\n", model.getName().split("/")[model.getName().split("/").length - 1]);

+                    System.out.println("\tMetadata:");
+                    System.out.format("\t\tType Url: %s\n", operation.getMetadata().getTypeUrl());
+                    System.out.format(
+                        "\t\tValue: %s\n", operation.getMetadata().getValue().toStringUtf8().replace("\n", ""));

+                      System.out.println("\tResponse:");
+                      System.out.format("\t\tType Url: %s\n", operation.getResponse().getTypeUrl());
+                      System.out.format(
+                          "\t\tValue: %s\n", operation.getResponse().getValue().toStringUtf8().replace("\n", ""));

+                    // Display the model information.
+                    System.out.format("Model name: %s\n", model.getName());
+                    System.out.format(
+                        "Model id: %s\n", model.getName().split("/")[model.getName().split("/").length - 1]);

Automl translation ga by nnegrey · Pull Request #1614 · GoogleCloudPlatform/java-docs-samples · GitHub

Uh oh!

Automl translation ga - #1614

Automl translation ga#1614nnegrey merged 12 commits intomasterGoogleCloudPlatform/java-docs-samples:masterfrom automl-translation-gaGoogleCloudPlatform/java-docs-samples:automl-translation-gaCopy head branch name to clipboard

Conversation

nnegrey commented Oct 14, 2019

Uh oh!

lesv commented Oct 14, 2019

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lesv commented Oct 16, 2019

Uh oh!

nnegrey commented Oct 16, 2019

Uh oh!

nnegrey commented Oct 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nnegrey commented Oct 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Automl translation ga#1614
nnegrey merged 12 commits into
masterfrom
automl-translation-ga

nnegrey commented Oct 17, 2019 •
edited
Loading