Moved Logs sample to Github - #166
Conversation
Sorry, something went wrong.
| import java.io.PrintWriter; | ||
| import java.util.Calendar; | ||
|
|
||
| //import javax.servlet.http.*; // Fix these to remove * import |
There was a problem hiding this comment.
Probably should remove this line.
Sorry, something went wrong.
|
Good to either assign to me, (or someone else if I'm not available). Or at least mention us using a @name. Please remove the two commented import statements. LGTM - once done. Feel free to merge. For comments, stuff about the API's is good, or anything tricky, but assume they know the language and how to program. (however, I'd much rather have too many, than too few. |
Sorry, something went wrong.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
|
Sorry, something went wrong.
|
@lesv Sorry to miss notifying you by name. I'll work on that. The import lines are fixed, but Travis still fails. I had updated the main pom.xml file. I still don't get what the iv error really means. Maybe @swast can drop by and show me how to fix this if he has some time. |
Sorry, something went wrong.
| @@ -0,0 +1,39 @@ | |||
| # Users Authentication sample for Google App Engine | |||
|
|
|||
| This sample demonstrates how to use the [Logs API][appid] on [Google App | |||
There was a problem hiding this comment.
I'd recommend something like [Logs API][log-docs] instead of [appid].
Sorry, something went wrong.
|
A few style nits, but LGTM overall. In the future, please create a new branch on this repo and make the pull request from there. That way Travis can run happily. Also, the CLA bot is not happy. You should make your GitHub profile use your @google.com email address per the Open Source policy. @lesv I'm not sure sure why Travis didn't run right away, but it appears that they and the GoogleBot caught up. |
Sorry, something went wrong.
|
@tswast Travis seems very broken at the moment. |
Sorry, something went wrong.
|
Travis is unhappy because it's from a fork instead of a branch. I have issue #117 open to fix that. Once the last fixes are in, I can run the tests manually before merging. |
Sorry, something went wrong.
Replaced Calendar class with org.joda.time.DateTime.
|
LGTM. Thank you! I'll merge after the tests pass on my local machine. |
Sorry, something went wrong.
|
Tests are failing due to testGetAllUsers(com.google.appengine.sparkdemo.UserControllerTest) in the sparkdemo tests, but that's unrelated to this change. It does get through all the tests except that one. I'll merge and hope it passes on Travis. |
Sorry, something went wrong.
…1.0 (#166) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `13.0.0` -> `13.1.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-notification).
Example from Logs (https://cloud.google.com/appengine/docs/java/logs/) moved to Github. No tests yet.