FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use test endpoint for datalabeling integration tests. by dzlier-gcp · Pull Request #1803 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

Use test endpoint for datalabeling integration tests. - #1803

Merged
dzlier-gcp merged 7 commits into
GoogleCloudPlatform:masterfrom
dzlier-gcp:datalabeling
Dec 17, 2019
ConversationCommits (7)ChecksFiles changed
Merged

Use test endpoint for datalabeling integration tests.#1803
dzlier-gcp merged 7 commits into
GoogleCloudPlatform:masterfrom
dzlier-gcp:datalabeling

Conversation

dzlier-gcp commented Dec 11, 2019

Copy link
Copy Markdown
Member

No description provided.

dzlier-gcp requested a review from a team December 11, 2019 23:01
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2019
dzlier-gcp requested a review from kurtisvg December 12, 2019 19:21
averikitsch requested changes Dec 13, 2019
View reviewed changes

averikitsch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since there is no ReadMe for this sample, do the docs mention the new environment variable "DATALABELING_ENDPOINT"?

Comment thread .kokoro/tests/run_tests.sh Outdated
Comment thread ...beling/beta/cloud-client/src/main/java/com/example/datalabeling/CreateAnnotationSpecSet.java Outdated
averikitsch reviewed Dec 13, 2019
View reviewed changes
Comment thread ...beling/beta/cloud-client/src/main/java/com/example/datalabeling/CreateAnnotationSpecSet.java
endpoint = DataLabelingServiceSettings.getDefaultEndpoint();
}

try (DataLabelingServiceClient dataLabelingServiceClient =

averikitsch Dec 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add comments to each file, that this is unnecessary for users to do or something to that effect.

kurtisvg Dec 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1. We should also add a comment why this is necessary for these snippets, and try to hide this portion from being staged in the documentation.

averikitsch Dec 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: It would be nice to still add a comment here (doesn't need to be in the staged version) to explain the extra code.

averikitsch commented Dec 13, 2019

Copy link
Copy Markdown
Contributor

Tests are not passing now that the variable typo was fixed.

kurtisvg suggested changes Dec 16, 2019
View reviewed changes
Comment thread ...beling/beta/cloud-client/src/main/java/com/example/datalabeling/CreateAnnotationSpecSet.java
endpoint = DataLabelingServiceSettings.getDefaultEndpoint();
}

try (DataLabelingServiceClient dataLabelingServiceClient =

kurtisvg Dec 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1. We should also add a comment why this is necessary for these snippets, and try to hide this portion from being staged in the documentation.

kurtisvg requested a review from averikitsch December 17, 2019 18:40

dzlier-gcp commented Dec 17, 2019

Copy link
Copy Markdown
Member Author

Justin suggested talking to Jeff Ching about moving this sample into the Datalabeling repo so that the tests are only triggered when an actual change to datalabeling goes through, instead of changing the endpoint we're targeting, so I'm going to check with him before submitting.

kurtisvg commented Dec 17, 2019

Copy link
Copy Markdown
Contributor

@dzlier-gcp Perhaps we should submit this now so that the current integration tests stop, and then move it in a different PR

dzlier-gcp merged commit cb61467 into GoogleCloudPlatform:master Dec 17, 2019
ivanmkc pushed a commit that referenced this pull request Nov 3, 2022
samples: Use test endpoint for datalabeling integration tests. (#1803)
596a244 
* Use test endpoint for datalabeling integration tests.

* Fix formatting

* Fix typo

* Fix formatting

* Add quotes to variable

* Add execeptions to method signitures.
ivanmkc mentioned this pull request Nov 3, 2022
Merged
9 tasks
averikitsch pushed a commit that referenced this pull request Nov 9, 2022
samples: Use test endpoint for datalabeling integration tests. (#1803)
17c6847 
* Use test endpoint for datalabeling integration tests.

* Fix formatting

* Fix typo

* Fix formatting

* Add quotes to variable

* Add execeptions to method signitures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

averikitsch averikitsch approved these changes
+1 more reviewer
kurtisvg kurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

kurtisvg

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL