FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: dataproc quickstart and createcluster by bradmiro · Pull Request #1908 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

feat: dataproc quickstart and createcluster - #1908

Merged
bradmiro merged 29 commits into
masterfrom
dataproc-samples
Dec 30, 2019
ConversationCommits (29)ChecksFiles changed
Merged

feat: dataproc quickstart and createcluster#1908
bradmiro merged 29 commits into
masterfrom
dataproc-samples

Conversation

bradmiro commented Dec 26, 2019

Copy link
Copy Markdown
Contributor
  • adding quickstart sample + test
  • updating createCluster + test
  • updating pom

bradmiro added 19 commits December 2, 2019 12:42
bradmiro requested a review from a team December 26, 2019 18:52
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 26, 2019
kurtisvg suggested changes Dec 26, 2019
View reviewed changes
Comment thread dataproc/src/main/java/Quickstart.java
Comment thread dataproc/src/test/java/CreateClusterTest.java Outdated
Comment thread dataproc/src/test/java/CreateClusterTest.java Outdated
Comment thread dataproc/src/test/java/CreateClusterTest.java
bradmiro requested a review from kurtisvg December 27, 2019 23:17
kurtisvg approved these changes Dec 28, 2019
View reviewed changes

kurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Couple of nits - PTAL

Comment thread dataproc/pom.xml Outdated
Comment thread dataproc/pom.xml
Comment thread dataproc/src/main/java/Quickstart.java
deleteClusterAsyncRequest.get();
System.out.println(String.format("Cluster \"%s\" successfully deleted.", clusterName));

} catch (ExecutionException e) {

kurtisvg Dec 28, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If ExecutionException occurs from interacting with the API (like it's thrown if you don't have permission or if your request is misconfigured), keep it and clarify that it's an error from interacting with the service with the println.

If it's not from the API, please let it bubble up (and be consistent with the other samples - it's bubbled up in a few other places).

bradmiro Dec 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ahh yes, I see what you're saying. Errors caused by our API bubble up to be an Execution Exception, so I think it should definitely be caught. I'll add it to the other sample.

kurtisvg commented Dec 28, 2019

Copy link
Copy Markdown
Contributor

You may also need to truncate your UUID:

INVALID_ARGUMENT: Cluster name 'java-dataproc-create-cluster-test-facb5e75-2e17-486c-9e22-e108bf8e8e63' must match pattern (?:[a-z](?:[-a-z0-9]{0,49}[a-z0-9]

bradmiro merged commit 287de72 into master Dec 30, 2019
bradmiro deleted the dataproc-samples branch December 30, 2019 21:51
olivi-eh pushed a commit that referenced this pull request Nov 11, 2022
samples: feat: dataproc quickstart and createcluster (#1908)
f78f8c0 
* Added dataproc quickstart samples

* Fixed linting, string formatting, copyrights

* added overloaded functions to all samples

* Formatting changes

* small bug fixes

* Fixed CreateCluster sample and added Quickstart

* Added quickstart sample

* Added dataproc quickstart samples

* Fixed linting, string formatting, copyrights

* added overloaded functions to all samples

* Formatting changes

* small bug fixes

* Fixed CreateCluster sample and added Quickstart

* Added quickstart sample

* Updates to createCluster and quickstart

* Fixed quickstart and tests

* Changes to tests

* Added periods to comments

* Fixed pom and added handling for ExecutionException

* Fixed lint errors

* Fixed linting errors
olivi-eh mentioned this pull request Nov 11, 2022
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
kurtisvg kurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

kurtisvg

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL