AppEngine Channel Example with Tic Tac Toe + Java - #191
Merged
lesv merged 3 commits intoApr 26, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
appengine/channel/pom.xml
Outdated
| <artifactId>appengine-maven-plugin</artifactId> | ||
| <version>${appengine.sdk.version}</version> | ||
| </plugin> | ||
| <plugin> |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
datanucleus doesn't appear to be used by the sample, you can remove the plugin.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Really cool! Same concerns as Les. Checkstyle is unhappy with the indentation in some places. From the Travis build: [INFO] Starting audit...
.../channel/Game.java:22: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:32: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:43: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:45: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:46: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:47: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:48: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:49: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:50: error: 'member def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:52: error: 'ctor def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:53: error: 'ctor def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:55: error: 'ctor def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:56: error: 'ctor def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:57: error: 'ctor def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:58: error: 'ctor def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:59: error: 'ctor def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:60: error: 'ctor def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:61: error: 'ctor def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:63: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:63:27: error: '{' at column 27 should have line break after.
.../channel/Game.java:63:40: error: '}' at column 40 should be alone on a line.
.../channel/Game.java:65: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:65:34: error: '{' at column 34 should have line break after.
.../channel/Game.java:65:50: error: '}' at column 50 should be alone on a line.
.../channel/Game.java:67: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:68: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:69: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:71: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:72: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:73: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:75: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:76: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:77: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:79: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:80: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:81: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:83: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:84: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:85: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:87: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:88: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:89: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:91: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:92: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:93: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:95: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:96: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:96: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:97: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:98: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:99: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:100: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:101: error: 'else' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:102: error: 'else rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:103: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:104: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:105: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:106: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:107: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:108: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:109: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:109: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:110: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:111: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:113: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:114: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:115: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:117: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:118: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:119: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:119: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:120: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:120: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:121: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:122: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:123: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:125: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:126: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:127: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:128: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:130: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:131: error: 'member def modifier' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:131: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:132: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:133: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:134: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:135: error: 'else' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:136: error: 'else rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:138: error: 'for' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:139: error: 'if' have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:140: error: 'if' have incorrect indentation level 16, expected level should be 8.
.../channel/Game.java:141: error: 'if' child have incorrect indentation level 20, expected level should be 10.
.../channel/Game.java:142: error: 'if rcurly' have incorrect indentation level 16, expected level should be 8.
.../channel/Game.java:143: error: 'else' child have incorrect indentation level 20, expected level should be 10.
.../channel/Game.java:144: error: 'else rcurly' have incorrect indentation level 16, expected level should be 8.
.../channel/Game.java:145: error: 'if' child have incorrect indentation level 16, expected level should be 8.
.../channel/Game.java:146: error: 'if rcurly' have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:147: error: 'for rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:148: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:150: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/Game.java:151: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:151: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:152: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:152: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:153: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:154: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:155: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:156: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:157: error: 'else' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:158: error: 'else' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:159: error: 'else rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:161: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:162: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:162: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:163: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:164: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:165: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:166: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:167: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:168: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/Game.java:169: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:171: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/Game.java:172: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/GetTokenServlet.java:15: error: Wrong lexicographical order for 'java.io.IOException' import. Should be before 'javax.servlet.http.HttpServletResponse'.
.../channel/GetTokenServlet.java:21: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/GetTokenServlet.java:23: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:23: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:24: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:24: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:25: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:25: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:26: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:26: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:28: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:28: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:29: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:29:51: error: '||' should be on a new line.
.../channel/GetTokenServlet.java:31: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/GetTokenServlet.java:31: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/GetTokenServlet.java:32: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/GetTokenServlet.java:32: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/GetTokenServlet.java:33: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/GetTokenServlet.java:34: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/GetTokenServlet.java:35: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/GetTokenServlet.java:36: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:37: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/GetTokenServlet.java:38: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/MoveServlet.java:11: error: Wrong lexicographical order for 'java.io.IOException' import. Should be before 'javax.servlet.http.HttpServletResponse'.
.../channel/MoveServlet.java:14: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/MoveServlet.java:16: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:16: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:17: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:17: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:18: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:18: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:19: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:19: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:20: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:20: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:22: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:22: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:23: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:24: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/MoveServlet.java:25: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:26: error: 'else' child have incorrect indentation level 12, expected level should be 6.
.../channel/MoveServlet.java:27: error: 'else rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/MoveServlet.java:28: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/OpenedServlet.java:12: error: Wrong lexicographical order for 'java.io.IOException' import. Should be before 'javax.servlet.http.HttpServletResponse'.
.../channel/OpenedServlet.java:18: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/OpenedServlet.java:20: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/OpenedServlet.java:20: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/OpenedServlet.java:21: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/OpenedServlet.java:21: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/OpenedServlet.java:22: error: 'try' have incorrect indentation level 8, expected level should be 4.
.../channel/OpenedServlet.java:23: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/OpenedServlet.java:23: error: 'try' child have incorrect indentation level 12, expected level should be 6.
.../channel/OpenedServlet.java:24: error: 'if' have incorrect indentation level 12, expected level should be 6.
.../channel/OpenedServlet.java:25: error: 'if' child have incorrect indentation level 16, expected level should be 8.
.../channel/OpenedServlet.java:26: error: 'if' child have incorrect indentation level 16, expected level should be 8.
.../channel/OpenedServlet.java:27: error: 'if' child have incorrect indentation level 16, expected level should be 8.
.../channel/OpenedServlet.java:28: error: 'if rcurly' have incorrect indentation level 12, expected level should be 6.
.../channel/OpenedServlet.java:29: error: 'else' child have incorrect indentation level 16, expected level should be 8.
.../channel/OpenedServlet.java:30: error: 'else rcurly' have incorrect indentation level 12, expected level should be 6.
.../channel/OpenedServlet.java:31: error: 'try rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/OpenedServlet.java:32: error: 'catch' child have incorrect indentation level 12, expected level should be 6.
.../channel/OpenedServlet.java:33: error: 'catch rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/OpenedServlet.java:34: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/TicTacToeServlet.java:14: error: Wrong lexicographical order for 'java.io.FileReader' import. Should be before 'javax.servlet.http.HttpServletResponse'.
.../channel/TicTacToeServlet.java:14:8: error: Unused import - java.io.FileReader.
.../channel/TicTacToeServlet.java:15: error: Wrong lexicographical order for 'java.io.IOException' import. Should be before 'javax.servlet.http.HttpServletResponse'.
.../channel/TicTacToeServlet.java:16: error: Wrong lexicographical order for 'java.net.URI' import. Should be before 'javax.servlet.http.HttpServletResponse'.
.../channel/TicTacToeServlet.java:17: error: Wrong lexicographical order for 'java.net.URISyntaxException' import. Should be before 'javax.servlet.http.HttpServletResponse'.
.../channel/TicTacToeServlet.java:18: error: Wrong lexicographical order for 'java.nio.CharBuffer' import. Should be before 'javax.servlet.http.HttpServletResponse'.
.../channel/TicTacToeServlet.java:18:8: error: Unused import - java.nio.CharBuffer.
.../channel/TicTacToeServlet.java:22: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/TicTacToeServlet.java:24: error: 'try' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:25: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:25: error: 'try' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:26: error: 'if' have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:27: error: 'if' child have incorrect indentation level 16, expected level should be 8.
.../channel/TicTacToeServlet.java:28: error: 'if rcurly' have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:29: error: 'else' child have incorrect indentation level 16, expected level should be 8.
.../channel/TicTacToeServlet.java:30: error: 'else rcurly' have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:31: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:31: error: 'try' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:32: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:32: error: 'try' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:39: error: 'try' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:40: error: 'try rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:41: error: 'catch' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:42: error: 'catch rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:44: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
.../channel/TicTacToeServlet.java:46: error: 'method def modifier' have incorrect indentation level 4, expected level should be 2.
.../channel/TicTacToeServlet.java:47: error: Line is longer than 100 characters (found 110).
.../channel/TicTacToeServlet.java:48: error: 'member def modifier' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:48: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:49: error: 'member def modifier' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:49: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:50: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:50: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:51: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:52: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:52: error: 'member def type' have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:52: error: Abbreviation in name must contain no more than '1' capital letters.
.../channel/TicTacToeServlet.java:53: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:53:61: error: '+' should be on a new line.
.../channel/TicTacToeServlet.java:54: error: Line is longer than 100 characters (found 111).
.../channel/TicTacToeServlet.java:56: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:57: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:59: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:59: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:60: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:60: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:61: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:61: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:62: error: 'if' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:63: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:64: error: 'if' have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:65: error: 'if' child have incorrect indentation level 16, expected level should be 8.
.../channel/TicTacToeServlet.java:66: error: 'if rcurly' have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:67: error: 'if' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:68: error: 'if rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:69: error: 'else' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:70: error: 'else' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:71: error: 'else' child have incorrect indentation level 12, expected level should be 6.
.../channel/TicTacToeServlet.java:72: error: 'else rcurly' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:74: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:74: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:75: error: 'member def type' have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:75: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:76: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:78: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:79: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:80: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:81: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:82: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:83: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:84: error: 'method def' child have incorrect indentation level 8, expected level should be 4.
.../channel/TicTacToeServlet.java:85: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.
|
Sorry, something went wrong.
saturnism
force-pushed
the
tictactoe
branch
2 times, most recently
from
ff66e7e to
55694fc
Compare
April 26, 2016 13:58
added 2 commits
April 26, 2016 15:19
Copy link
Copy Markdown
Contributor
|
LGTM - Thank you very much! |
Sorry, something went wrong.
minherz
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [0.120.1](https://www.github.com/googleapis/java-errorreporting/compare/v0.120.0...v0.120.1) (2020-08-10) ### Bug Fixes * **v1beta1:** migrate to grpc_service_config ([#195](https://www.github.com/googleapis/java-errorreporting/issues/195)) ([3a2ddcf](https://www.github.com/googleapis/java-errorreporting/commit/3a2ddcfb8da2f376be800c62b32f96b271d9f1d2)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#189](https://www.github.com/googleapis/java-errorreporting/issues/189)) ([fb6dbc7](https://www.github.com/googleapis/java-errorreporting/commit/fb6dbc7633397761772d812fa9f55923ea0ca006)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#193](https://www.github.com/googleapis/java-errorreporting/issues/193)) ([cdbb26b](https://www.github.com/googleapis/java-errorreporting/commit/cdbb26b95b4e9d90d664c91210512c70d112acde)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#198](https://www.github.com/googleapis/java-errorreporting/issues/198)) ([0d29ee2](https://www.github.com/googleapis/java-errorreporting/commit/0d29ee2023c45a49a08d0c8b08e1571137500cd1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is adapted from https://code.google.com/archive/p/java-channel-tic-tac-toe/