FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add cli functionality to dataproc quickstart by bradmiro · Pull Request #2047 · GoogleCloudPlatform/java-docs-samples · GitHub

feat: add cli functionality to dataproc quickstart - #2047

Merged
bradmiro merged 7 commits into
masterfrom
dataproc-samples
Feb 3, 2020
Merged

feat: add cli functionality to dataproc quickstart#2047
bradmiro merged 7 commits into
masterfrom
dataproc-samples

Conversation

Copy link
Copy Markdown
Contributor

I made the Dataproc quickstart runnable and provided instructions on how to run it with maven.

bradmiro requested review from a team and kurtisvg January 30, 2020 16:41
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020

kurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We strongly prefer not to have CLI components for Java samples. The reason for this is that the vast majority of users use an IDE, and copy and paste the snippets from the doc site. They should be able to run the sample in their IDE, as they may not be comfortable with the command-line.

If you absolutely have to have interaction via command-line, you can reformat the existing no-args quickstart to a Main function and include instructions to edit the snippet to run the main class. This allows it to be run from the command-line while still preserving the ability for the function to be triggered in an IDE easily.

kurtisvg assigned kurtisvg and unassigned gguuss Jan 30, 2020

Copy link
Copy Markdown
Contributor Author

Given that this is an E2E tutorial, I discussed with the TW and we agreed that all of the "quickstart" samples in all languages should be runnable as-is without modifying any code (including uncommenting and setting variables). This is the only sample we intend to do this for and the rest will follow the traditional framework, such as the createCluster sample. I definitely acknowledge we're making atypical trade-offs to create this functionality.

bradmiro requested a review from kurtisvg February 3, 2020 21:49
bradmiro merged commit 6dd3dba into master Feb 3, 2020
bradmiro deleted the dataproc-samples branch February 3, 2020 22:24
olivi-eh pushed a commit that referenced this pull request Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL