small changes test and added sleep time between search func - #2547
Merged
lesv merged 6 commits intoApr 1, 2020
Merged
lesv merged 6 commits into
lesv merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lesv
approved these changes
Apr 1, 2020
lesv
approved these changes
Apr 1, 2020
Comment on lines
+34
to
+36
| * <p>- Construct a featured job | ||
| * | ||
| * - Search featured job | ||
| * <p>- Search featured job |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Doc samples don't need <p>
Sorry, something went wrong.
| // requisition id should be a unique Id in your system. | ||
| String requisitionId = | ||
| "featuredJob:" + String.valueOf(new Random().nextLong()); | ||
| String requisitionId = "featuredJob:" + String.valueOf(new Random().nextLong()); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Ok, but it's better to use a real UUID than a Random as that's not guaranteed to truly be random.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I will make these changes
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2261 #2232